Closed subz3r0o0 closed 6 months ago
Erioldoesdesign
commented
6 months ago @subz3r0o0 Could you kindly do a short screen recording of this PR's changes visually? I haven't got a development environment set up but to me your code looks good.
Also pinging a few others that might have a dev environment set up so also check :)
subz3r0o0
commented
6 months ago I made changes to the base.scss file and to the index.html. Just a few lines altered. Hope you can view the video, let me know if not. Thanks !
Erioldoesdesign
commented
6 months ago trim.45B65E1B-F08F-4B9A-B08D-60E3298BFF9B.MOV I made changes to the base.scss file and to the index.html. Just a few lines altered. Hope you can view the video, let me know if not. Thanks !
Ah sorry I wasn't clear - a video of how the behaviour looks on the button now the changes have been made - so visually what happens on the button icon - sorry I wasn't clear 😅
subz3r0o0
commented
6 months ago Hi,I am currently at work and I can only record it from my home computer. Is it ok if I send it later ? Regards
Sent from Yahoo Mail for iPhone
On Tuesday, April 30, 2024, 11:55 am, Eriol Fox @.***> wrote:
trim.45B65E1B-F08F-4B9A-B08D-60E3298BFF9B.MOV I made changes to the base.scss file and to the index.html. Just a few lines altered. Hope you can view the video, let me know if not. Thanks !
Ah sorry I wasn't clear - a video of how the behaviour looks on the button now the changes have been made - so visually what happens on the button icon - sorry I wasn't clear 😅
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
Erioldoesdesign
commented
6 months ago Hi,I am currently at work and I can only record it from my home computer. Is it ok if I send it later ? Regards Sent from Yahoo Mail for iPhone On Tuesday, April 30, 2024, 11:55 am, Eriol Fox @.> wrote: trim.45B65E1B-F08F-4B9A-B08D-60E3298BFF9B.MOV I made changes to the base.scss file and to the index.html. Just a few lines altered. Hope you can view the video, let me know if not. Thanks ! Ah sorry I wasn't clear - a video of how the behaviour looks on the button now the changes have been made - so visually what happens on the button icon - sorry I wasn't clear 😅 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>
No problem at all :) take your time
subz3r0o0
commented
6 months ago Hi, will this pull request be approved? Thanks
subz3r0o0
commented
6 months ago Hi, if available, would it be possible to check this PR?
@SaptakS, @AnXh3L0
I moved the Open Collective logo SVG to the base HTML file. I extended the button lg. class for SVGs - one for hover, one for default. This was to ensure the SVG matched the Font Awesome icons. Now SVG goes white on hover, corresponding with other boxes.