search

opensourcedesign / opensourcedesign.github.io

🎨💻 Source code of our website
https://opensourcedesign.net
Apache License 2.0
356 stars 188 forks source link

Event list and job list not appear in homepage- Firefox43 and Chrome48 runs on OSX 10.11.1 #51

Closed digitigrafo closed 8 years ago

digitigrafo commented 8 years ago

schermata 2016-01-25 alle 11 15 41 Also in Chrome 48, the same thing.

simonv3 commented 8 years ago

They don't appear anywhere, they're not really implemented properly yet...

Happy to accept PRs fixing this though!

jancborchardt commented 8 years ago

Yup, same here, was contacted on IRC already by a person who noted there are no future events.

We did show them in the past though, no? How was it broken and how can we fix it? cc @gillisig @bnvk

jancborchardt commented 8 years ago

If it’s more work then we should put a link to the Events / Jobs pages at least. Or is it a quick fix?

bnvk commented 8 years ago

We did show them in the past though, no? How was it broken and how can we fix it? cc @gillisig @bnvk

I think there is a few ways to go about this- one would be with JS + ajax calls, the other would be using Jekyll and pull in the sub-repo data!

If it’s more work then we should put a link to the Events / Jobs pages at least. Or is it a quick fix?

There are links at the top of the page. But adding a button to the bottom like "See all events" makes sense!

simonv3 commented 8 years ago

It really shouldn't be too much work, and we never had an "events" or a "jobs" feed on the front page.

I half-assed implemented something but just hadn't had time to look at it again.

dominicrico commented 8 years ago

Fixed with #52 Filled in six events and jobs instead of the whole list, because they could be really long over time. Maybe a pagination or something else would be nice.

simonv3 commented 8 years ago

This is great. Thanks @dominicrico.

Live on the site now :) opensourcedesign.net

dominicrico commented 8 years ago

Glad to see it live that quick! Will do more soon!

bnvk commented 8 years ago

@dominicrico awesomely done! Thanks so much for contributing :+1: