Closed simonv3 closed 7 years ago
@simonv3 It's very easy to setup. You can use the hosted version at (https://orgmanager.miguelpiedrafita.com) or host it yourself (https://github.com/m1guelpf/orgmanager).
Do you mind setting it up for OSD so we can try it out?
@simonv3 The hosted one or the selfhosted one?
@m1guelpf either! If you think the hosted one is enough then that would be great :)
@simonv3 The hosted one should work... You just need to register on the hosted version with a Github account that has admin permissions to this org. If you need more help, you can either ask here or use the chat provided in the website.
Hmm, does the application automatically create links for all orgs that I'm an admin for? That's not desirable on my end.
Also, what does it mean to "Sync" and to "submit" something? And how does the password protection work?
@simonv3 You should give access to the organizations you want to generate links for. The sync function syncs the ORG name and description from Github. To enable password-protection, just enter any password in the password field and press submit. To remove it, remove the password from the password field and press submit.
I don't see a way to specifically only give access to some organizations. I'm not sure GitHub allows for that - it defaults to the organization's permissions in relation to the user I thought.
@simonv3 You can check, give and remove permissions and organizations to orgmanager at this link: https://github.com/settings/connections/applications/10b01d866046f040c9f1
@m1guelpf can we take this to a chat. I don't think I can edit anything on that page specifically. It automatically checks all the organizations that I'm a member of, and I don't think there's a way to unselect them unless I'm missing something.
This might be a limitation on GitHub's authentication system, but in the mean time I still don't want to have organization join links available for orgs that I don't want people to have access to if they stumble across a URL.
Also, when I set a password for my third application in the list (as a workaround to not having these URLs being available) and I click "update" it updates the wrong orgs settings :/ It looks like it updates the index-1 setting, but it doesn't submit the password.
(Not to sound too negative, this looks like it's exactly what we need, there just seem to be a couple of glitches, thanks for building it!!)
@simonv3 Could you send me an screenshot of the page where you can't cancel your org permissions. Also, could you open an issue for that password glitches? I am not able to chat over irc, but you can email me or use the chat of the website (that goes to my mail anyway :smile:).
Screenshot:
The green arrows aren't toggles, they're just links to this page: https://help.github.com/articles/about-third-party-application-restrictions/
I've opened some other issues as well.
Awesome, thanks to the quick response time by @m1guelpf this might be an option:
@simonv3 Just checked to see if this worked, and it gives an error. Seems like your github token is invalid. Could you revoke the orgmanager permission and try to login again? (You can revoke it in the link i sent you before) Thank you!
@m1guelpf went ahead and did that.
looks like it's the same link, but try again? https://orgmanager.miguelpiedrafita.com/join/4183553
Awesome! :) Then we can finally add a link for people to add themselves.
@m1guelpf is there also an easy way to have the visibility of people set to »Public« by default? The current standard of »Private« is a bit annoying because we have to ask everyone.
@jancborchardt There isn't an API endpoint to do that for security reasons, and also it would not be possible as the user needs to accept the invitation before we can modify status via the API. Sorry 😞
Also, if you have some ideas/things that orgmanager could do, feel free to open an issue in the repo, as after releasing v2.0 I've run out of ideas 😄
@m1guelpf awesome! I opened a bunch of issues :)
@jancborchardt Thank you!
@simonv3 @jancborchardt I've noticed you used to add your users to an organization team (https://github.com/orgs/opensourcedesign/teams/people). I've just deployed a new fuction that allows you to select a group users will go into. You can access it in the organization settings in OrgManager.
Oh great, knew we were forgetting something.
And done. That was the last piece of the puzzle. Thanks so much for being so responsive @m1guelpf, this is awesome.
@simonv3 @jancborchardt I've recieved multiple messages of users that can't join OSD using OrgManager. I've debugged and the cause seems to be a GitHub authorization error: "You must be an organization owner or team maintainer to add a team membership." It seems that the person who registered OSD into OrgManager's privileges were revoked and that person no longer has admin access to the People team. Could you investigate this?
Wasn't I that person?
Edit: I still have access to the People team as admin.
When I log in to orgmanager everything looks fine, except for when I click on "sync teams" I get "Whoops, looks like something went wrong".
@simonv3 Reading the logs, it seems like GitHub throwed an unauthorized issue with "Must have admin rights to Repository" when you tried to sync teams...
@m1guelpf I have admin rights though. Are you sure it's requesting the rights in my name?
@simonv3 I've just tried to retry the requests manually, and here is the response:
@simonv3 I've deleted the GitHub token fron the database, could you please logout and login again?
@m1guelpf I did and no luck. Maybe we should chat on IRC?
@simonv3 I can't connect to IRC, but maybe we can chat in the OrgManager Gitter channel: https://gitter.im/orgmanager
@simonv3 Also, could you try to revoke the OrgManager oAuth permission and login again (https://github.com/settings/connections/applications/10b01d866046f040c9f1) or, if that doesn't work, maybe another admin can sign up and I can manually change the user ID in the database... It seems to be working for the rest of organizations...
Seems like Gitub had revoked somehow the permissions for OrgManager... fixed now. I will open a ticket with GitHub later to know more... Thank you @simonv3 !
Thank you @m1guelpf!
@simonv3 @jancborchardt Just wanted to drop that https://github.com/orgmanager/orgmanager/issues/48 was just closed, and now you can set a custom message that will be displayed to users when they're invited. It's a good place to ask people to accept your invite and change their membership to public!
@m1guelpf awesome! :) @simonv3 can you maybe adjust that to ask people to accept and set their visibility to public?
I already did!
@m1guelpf mentioned this platform: https://orgmanager.miguelpiedrafita.com/
Can we use this for automatically letting people join OSD rather than us always having to invite them?