opensourcediversity / opensourcediversity.org

🌼 Code of https://opensourcediversity.org
https://opensourcediversity.org
GNU Affero General Public License v3.0
240 stars 89 forks source link

create github action workflow for linting html #154

Closed Roshanjossey closed 1 year ago

Roshanjossey commented 1 year ago

address: #142

sleepypioneer commented 1 year ago

I am probably not too knowledgeable about this so excuse the possibly silly question @Roshanjossey :) – should the lint not run through properly on this pull request then? As it seems it failed.

The failing one is the old circle CI linter. The new one doesn't appear to have run here.

Roshanjossey commented 1 year ago

I tried this in my fork before raising a PR here. https://github.com/Roshanjossey/opensourcediversity.org/pull/3

Lint action runs there and fails with expected error messages.

My theory about it not running here is that there is higher security restriction here to prevent workflows in PRs running

sleepypioneer commented 1 year ago

I see the following

Screenshot 2023-05-08 at 21 35 05

I selected option 3 : allow opensourcediversity ....

sleepypioneer commented 1 year ago

probably we need some change, maybe close and reopen this PR? reading here I think that would do it

sleepypioneer commented 1 year ago

hmm still not running 🤔 maybe we can change it to on push? I would have to read up more on which of those options that we can choose from for actions should be selected perhaps it needs to be less restictive

sleepypioneer commented 1 year ago

I changed the settings for including github created actions (somehow thought this would have been default 🤪 )

sleepypioneer commented 1 year ago

ok sorry @Roshanjossey I got there now 😅 The setting I chose did not include github created actions, I noticed here the following:

--

Error: .github#L1 actions/checkout@v2 is not allowed to be used in opensourcediversity/opensourcediversity.org. Actions in this workflow must be: within a repository owned by opensourcediversity.

sleepypioneer commented 1 year ago

now it runs but fails because of the following reasons:

line 195 column 119 - Warning: unescaped & or unknown entity "&I" line 196 column 53 - Warning: unescaped & or unknown entity "&I" line 34 column 33 - Warning: trimming empty

as it's not very many do you want to fix them here?

Roshanjossey commented 1 year ago

Thank you for following up @sleepypioneer. Ended up fixing #152 too when fixing lint errors