No receipt on non-taxable sale Item #1829

sqvquilter commented 6 years ago

Background information

IMPORTANT: If you choose to ignore this issue report template, your issue will be closed as we cannot help without the requested information.

Please make sure you tick (add an x between the square brackets with no spaces) the following check boxes:

[x] Reporting an issue of an unmodified OSPOS installation
[x] Checked open and closed issues and no similar issue was already reported (please make sure you searched!)
[x] Read README, WHATS_NEW and UPGRADE
[x] Read the FAQ for any known install and/or upgrade gotchas (in specific PHP extensions installed)
[x] Read the wiki
[x] Executed any database upgrade scripts if an upgrade pre 3.0.0 (e.g. database/2.4_to_3.0.sql)
[x] Aware the installation code is in bintray (see README), and GitHub master is for developers only and therefore not complete nor stable

Installation information

OSPOS version is: 3.2.0
OSPOS git commit hash is: 4f5ad57
PHP version is: (e.g. 5.5, 5.6, 7.0, 7.1) 7.1.9
MySQL or MariaDB version is: (e.g. MySQL 5.5, MySQL 5.6, MySQL 5.7, MariaDB 10.0, MariaDB 10.1, MariaDB 10.2) MySQL 5.7.19
OS and version is: (e.g. CentOS 6.9, Ubuntu 16.4, Windows 10) Windows 10
WebServer is: (e.g. Apache 2.2, Apache 2.4, Nginx 1.12, Nginx 1.13) Apache 2.4.27
(If applicable) Docker installation:
(If applicable) Installation package for the LAMP/LEMP stack is: (e.g. WAMP, XAMPP)

Issue / Bug / Question / New Feature

Please write your issue here. If a bug, please make sure to provide as much information as possible including configuration settings (e.g. Decimals set, Tax mode), language and steps to reproduce the bug.

This is the same as item #1829. That issue was closed with a comment about modified code. The code has not been modified. I reinstalled a clean version and got the same results. I generally like what I see with OSPOS and would like to use unmodified code. Modifying the code would complicate taking advantage of any future enhancements that are made, so I would prefer to not modify the code. That said many businesses need to use both taxable and non-taxable items. The only way I have been able to make this work is to put the sales tax on each individual item. While this works it is not as desirable as being able to set the sales tax in one place. Setting the sales tax for each item is asking for data entry errors and thus tax issues. Please reconsider this issue as the code is unmodified.

When item sold is not taxable pressing the complete button yields blank screen - no sales receipt is displayed. Configurations for taxes is taxcode taxconfig Taxable item setup taxitem Non taxable item is nontaxitem

Expected behavior would be to show sales receipt like taxable sale. expectedsale expectedcomplete Actual result No receipt displayed and sale is not complete. errorsale errorcomplete