opensourcepos / opensourcepos

Open Source Point of Sale is a web based point of sale application written in PHP using CodeIgniter framework. It uses MySQL as the data back end and has a Bootstrap 3 based user interface.
http://www.opensourcepos.org
Other
3.48k stars 2.19k forks source link

Updating composer.json #3629

Closed objecttothis closed 1 year ago

objecttothis commented 1 year ago

Below is the CI 4.3.1 composer.json file. There are several dependencies that are NOT in the OSPOS composer.json. The question is do we need to incorporate these dependencies into the OSPOS composer.json so that it does not break any CI features? @jekkos @daN4cat can you guys weigh in on this? My only question is whether doing so causes a problem with the automatic builds. I've added <-- next to the items that I'm wondering if we should include?

{
    "name": "codeigniter4/framework",
    "type": "project",
    "description": "The CodeIgniter framework v4",
    "homepage": "https://codeigniter.com",
    "license": "MIT",
    "require": {
        "php": "^7.4 || ^8.0",
        "ext-intl": "*", <--
        "ext-json": "*" <--,
        "ext-mbstring": "*", <--
        "laminas/laminas-escaper": "^2.9", <--
        "psr/log": "^1.1" <--
    },
    "require-dev": {
        "kint-php/kint": "^5.0.1", <--
        "codeigniter/coding-standard": "^1.5", <--
        "fakerphp/faker": "^1.9",
        "friendsofphp/php-cs-fixer": "3.13.0", <--
        "mikey179/vfsstream": "^1.6", <--
        "nexusphp/cs-config": "^3.6", <--
        "phpunit/phpunit": "^9.1",
        "predis/predis": "^1.1 || ^2.0" <--
    },
    "suggest": { <--
        "ext-curl": "If you use CURLRequest class", <--
        "ext-imagick": "If you use Image class ImageMagickHandler", <--
        "ext-gd": "If you use Image class GDHandler", <--
        "ext-exif": "If you run Image class tests",
        "ext-simplexml": "If you format XML",
        "ext-mysqli": "If you use MySQL", <--
        "ext-oci8": "If you use Oracle Database",
        "ext-pgsql": "If you use PostgreSQL",
        "ext-sqlsrv": "If you use SQL Server",
        "ext-sqlite3": "If you use SQLite3",
        "ext-memcache": "If you use Cache class MemcachedHandler with Memcache",
        "ext-memcached": "If you use Cache class MemcachedHandler with Memcached",
        "ext-redis": "If you use Cache class RedisHandler",
        "ext-dom": "If you use TestResponse",
        "ext-libxml": "If you use TestResponse",
        "ext-xdebug": "If you use CIUnitTestCase::assertHeaderEmitted()",
        "ext-fileinfo": "Improves mime type detection for files", <--
        "ext-readline": "Improves CLI::input() usability" <--
    },
    "autoload": { <--
        "psr-4": { <--
            "CodeIgniter\\": "system/" <--
        },
        "exclude-from-classmap": [ <--
            "**/Database/Migrations/**" <--
        ]
    },
    "scripts": { <--
        "post-update-cmd": [ <--
            "CodeIgniter\\ComposerScripts::postUpdate" <--
        ],
        "test": "phpunit" <--
    },
    "support": { <--
        "forum": "https://forum.codeigniter.com/",
        "source": "https://github.com/codeigniter4/CodeIgniter4",
        "slack": "https://codeigniterchat.slack.com"
    }
}
jekkos commented 1 year ago

@objecttothis If I remember well, I had issues with the ext- dependencies in the CI Docker build. I think the conclusion was that they are runtime dependencies and not needed at compile time. We should try to limit dependency set as much as possible. I updated the json in the ci4-upgrade branch and got to the point of running the tests. I'll continue on that part once we have the app itself running

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

objecttothis commented 1 year ago

Since @SteveIreland has gotten the build working successfully, I think we should close this for now.