search

opensourcerouting / c-capnproto

C library/compiler for the Cap'n Proto serialization/RPC protocol
MIT License
118 stars 40 forks source link

Fix runtime library compiler warnings and errors in GCC. #15

Closed fluffysquirrels closed 7 years ago

fluffysquirrels commented 7 years ago

I tested these changes with make check and by building the runtime library in my own project.

fluffysquirrels commented 7 years ago

Thanks for the review, I'll get working on the changes.

fluffysquirrels commented 7 years ago

I think I've completed all the changes we discussed. I've tested this by building my project and running make check in c-capnproto.

eqvinox commented 7 years ago

Thanks a lot for your fixes :)

fluffysquirrels commented 7 years ago

No problem, thanks for the reviews. :)

I'm thinking of working on issue 13 to provide example usage of c-capnproto in the documentation. I thought about writing the example as a unit test and linking to that from README.md.

Any thoughts on this? Would you be happy to see a pull request?

eqvinox commented 7 years ago

Absolutely - this really needs docs; I just don't have the time to put something together... (it's actually been half a year since I last touched any Cap'n Proto related code.)

(For our own application, it took me quite a lot of scraping and mistakes to figure out how to call this stuff correctly... unfortunately it's rather deeply mangled inside our code so it's not really an useful example... I can see if I can dig it out and post it somewhere.)