opensourcerouting / frr

Free Range Routing Protocol Suite
Other
37 stars 12 forks source link

New config parameter (msd) in pcc configuration #11

Closed rampxxxx closed 4 years ago

rampxxxx commented 4 years ago

Now MSD (Maximum SID Depth) is not sended to remote PCE in open message, fix that taking value from configuration even the ideally feature is getting from isis (which should be a future fix).

Both PCE tested (Cisco and ODL) requires flag sr-draft07 in pce configuration for the MSD value to be processed.

It's been tested

  1. In cisco it's been checked with show pce ipv4 peer detail
  2. In ODL with karaf log (log:set DEBUG)
sylane commented 4 years ago

From what I could see, Cisco is understanding the "Aggregate Bandwidth Consumption" metric as the "Max SID Depth", and this should be fixed in some ways through a special profile for Cisco or something similar. This MSD is somehow different, I am curious about the interaction between the two. With this PR, does the Cisco PCE still requiring the metrics ?

rampxxxx commented 4 years ago

There are two levels of msd one per node (pcc) and another per lsp. The "abc" metric is used by cisco as the lsp msd (which I think is a bug). This fix has been tested in ODL PCE and CISCO PCE and both read the global msd properly