@bradyallenjohnson cool stuff! I always wanted to have something like this :)
Just two comments:
The formatting seems to be off, can you run clang-format over this again?
sprintf is discouraged in FRR, instead snprintf should be used. Same goes for strcat, strcpy but I think you don't use those. This can IMHO also be fixed in another PR for the overall module code (there are other places with sprintf).
@bradyallenjohnson cool stuff! I always wanted to have something like this :)
Just two comments:
sprintf
is discouraged in FRR, insteadsnprintf
should be used. Same goes for strcat, strcpy but I think you don't use those. This can IMHO also be fixed in another PR for the overall module code (there are other places with sprintf).