search

openspout / openspout

Read and write spreadsheet files (CSV, XLSX and ODS), in a fast and scalable way
https://github.com/openspout/openspout/tree/4.x/docs
MIT License
825 stars 102 forks source link

Handling of time cells is not consistent for different readers #137

Open stof opened 1 year ago

stof commented 1 year ago

When reading a time cell in an ODS file, a DateIntervalCell is used. When reading a XLSX file, a DateTimeCell is used (and I don't know which date it has). This makes it hard to write code that can support both XLSX and ODS as it forces to handle different cell types (both for reading and for writing). It would be great to have a common abstraction between those readers and writers to make the code common.

stof commented 1 year ago

@Slamdunk is this something that is supposed to be abstracted properly ?

Slamdunk commented 1 year ago

I haven't dug this, sorry.

If you are able to reasoning of the topic & code and propose a comprehensive solution in a PR, I'd be glad to review and merge it :muscle:

stof commented 1 year ago

I don't have an idea right now but I'll try to think about it.