search

openspyrit / spyrit

A Python toolbox for deep image reconstruction, with emphasis on single-pixel imaging.
https://spyrit.readthedocs.io/en/master
GNU Lesser General Public License v3.0
41 stars 15 forks source link

Denoising layer of DC Net #219

Open nducros opened 3 months ago

nducros commented 3 months ago

https://spyrit.readthedocs.io/en/master/_autosummary/spyrit.core.recon.Denoise_layer.html#spyrit.core.recon.Denoise_layer

romainphan commented 3 months ago

corrected

https://github.com/openspyrit/spyrit/pull/221/commits/6628dee8403a3ff04dfa767bd9e2c99d82e31343

nducros commented 3 months ago

The doc is confusing as the denoise layer only computes the filter (a / a + b), which is designed to be multiplied to some input measurement vector. The usage of the filter is only visible here: https://github.com/openspyrit/spyrit/blob/aa1739794e206e9441ccc228a0b77a2be6e087f9/spyrit/core/recon.py#L191

The design of the class seems awkward, as the forward function should actually compute what the doc says, i.e., (a / a + b) input

romainphan commented 2 months ago

https://github.com/openspyrit/spyrit/issues/228