search

opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
54 stars 41 forks source link

P2P - Provide unique device identification through wifi-direct name or extra authentication step #1136

Open ekigamba opened 2 years ago

pld commented 2 years ago

what is the unique ID we are using here? is wifi-direct name guaranteed unique?

ekigamba commented 2 years ago

@pld The idea was to use the users name together with the phone make and model. Currently, only the phone make and model are used as the device title up when searching for other devices or when prompted to connect.

Given that the CHAs and CHWs have same devices and are going to be close together when performing p2p, it might be confusing to identify who the target user is in such a scenario

pld commented 2 years ago

Is there a reason why this can't be generated by the app? Like what if when the app runs the first time it creates and stores a UUID, and we use that, are there any problems w/that given our requirements?

ekigamba commented 2 years ago

The issue is not generating this but rather providing this identifier during connection. When searching for devices to connect to, multiple devices with the same name will show up i.e. Samsung Tab A, Samsung Tab A, making it difficult for the sender or receiver to identify the specific device they want to connect to since the device names don't have the username.

pld commented 2 years ago

OK I see, so it needs to be user understandable, your approach makes sense