[Offline Login] App force closes on offline login

opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.

https://opensrp.io

Apache License 2.0

55 stars 56 forks source link

[Offline Login] App force closes on offline login #1907

Closed dubdabasoduba closed 1 year ago

dubdabasoduba commented 1 year ago

App version 0.1.7- preview Phone: Grandblue G6 When trying to log in while offline - the app is giving an error in configs and then force closing after I enter the pin.

https://user-images.githubusercontent.com/58034047/207848949-81615310-6a50-4bbd-9c0a-cb0ec9501a53.mp4

Acceptance criteria

[ ] User should be able to log in while offline.
[ ] While offline and for subsequent logins - the user should be redirected to the pin login page (not the username/password page).

allan-on commented 1 year ago

I tested this from the emulator and a Samsung device and I believe it's been resolved. The app doesn't crash on offline login using a set PIN

pld commented 1 year ago

Can you add some additional testing around this?

f-odhiambo commented 1 year ago

Assigning @allan-on to this. You can tag the open PR to this ticket to close it too and add some more test as requested by @pld

dubdabasoduba commented 1 year ago

Closing this. Since the attached PR fixes it. https://github.com/opensrp/fhircore/pull/1898