opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://opensrp.io
Apache License 2.0
59 stars 59 forks source link

Add Register filtering #2698

Closed allan-on closed 1 year ago

allan-on commented 1 year ago

Describe the feature request. This is a new advanced ability for the user/practitioner to filter the register based on any or all of the supported attributes.

Feature mockup image

Additional context See discussions on this feature

Acceptance criteria

allan-on commented 1 year ago

Reopening this because only Add Register filter UI and configs is done (closed by https://github.com/opensrp/fhircore/pull/2744). Implement filtering of register records is still pending (previously blocked but is now unblocked after the merging of Migrate to latest FHIR engine SDK).

allan-on commented 1 year ago

@f-odhiambo @ellykits From the designs shared with the design team, the count of filtered records should be updated in the count badge as seen in the mocks (3). @HenryRae @rowo Do we need to update the count showing on the navigation drawer as well? In my opinion, having the count on the nav drawer showing the total count of records in that register and the badge showing count of filtered records, should suffice?

allan-on commented 1 year ago

The last task

Clearing all filters should reload the register and display clients in that register based on the register config dataQueries + filterCriteria

in Implement filtering of register records #2764 will be completed after the Google FHIR SDK functionality Clear all action on Questionnaire and functionality to change text on submit action button #2221 is done

rowo commented 1 year ago

@allan-on did you get this question answered? The nav drawer number is the total count for that register. The badge shows the number of filters in place I think but @HenryRae correct me if I'm wrong. On the actual filter screen itself, I think it would be a nice to have to show the matching results once filters are selected (like done on sites like Airbnb), but that's not necessary right now.

allan-on commented 1 year ago

Hi, @rowo Thanks for the clarification. The current implementation is as you've described.

HenryRae commented 1 year ago

This is correct, alternatively quick solution would be showing just red dot without count.

pld commented 1 year ago

@allan-on what's remaining here now that https://github.com/opensrp/fhircore/issues/2764 is closed?

allan-on commented 1 year ago

Hi @pld There is this one remaining bit

The last task

Clearing all filters should reload the register and display clients in that register based on the register config dataQueries + filterCriteria

in Implement filtering of register records #2764 will be completed after the Google FHIR SDK functionality Clear all action on Questionnaire and functionality to change text on submit action button #2221 is done

The filters are still usable without this feature, but this issue is still open for tracking that last remaining bit.

pld commented 1 year ago

OK yea, cool, will close this that's a separate feature that is useful here and elsewhere