opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

[P2P] Validate the need for using a custom query for P2P #2729

Closed Rkareko closed 9 months ago

Rkareko commented 9 months ago

A datetime index and custom search query were added as part of the performance improvements of P2P on the FHIRCore codebase.

Since then various updates on the Android FHIR SDK have been implemented in order to improve app performance.

We need to validate whether the custom index and query are still needed on FHIR Core codebase.

Rkareko commented 9 months ago

Initial tests using staging data show that after removing the custom index and query in FHIR Core P2P transfer speeds slightly improved.

It took 40 minutes to transfer 45253 records with the custom index and query in place.

After removing the custom query and index it took 32 minutes to transfer 45353 records.

QA team may need to run their own tests to validate this as well as verify that data is being transferred correctly.

pld commented 9 months ago

Cool that's a 25% reduction in speed, that's definitely an improvement!