opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
53 stars 41 forks source link

Make Login Screen Logo Size Configurable #3045

Closed hamza-vd closed 7 months ago

hamza-vd commented 7 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Required to match mockup mentioned in here

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: 414 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (0afa08a) 65.7%. Report is 166 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3045 +/- ## ========================================= + Coverage 64.5% 65.7% +1.1% - Complexity 1075 1130 +55 ========================================= Files 218 235 +17 Lines 9635 10882 +1247 Branches 1897 1985 +88 ========================================= + Hits 6218 7153 +935 - Misses 2234 2477 +243 - Partials 1183 1252 +69 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `68.8% <62.7%> (-3.9%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.5% <ø> (+1.1%)` | :arrow_up: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `63.6% <ø> (+4.7%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...ter/fhircore/engine/configuration/Configuration.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uLmt0) | `25.0% <100.0%> (ø)` | | | [...ngine/configuration/event/EventTriggerCondition.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9ldmVudC9FdmVudFRyaWdnZXJDb25kaXRpb24ua3Q=) | `50.0% <ø> (ø)` | | | [...r/fhircore/engine/configuration/event/EventType.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9ldmVudC9FdmVudFR5cGUua3Q=) | `100.0% <ø> (ø)` | | | [...core/engine/configuration/view/ColumnProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0NvbHVtblByb3BlcnRpZXMua3Q=) | `100.0% <ø> (ø)` | | | [...ngine/configuration/view/CompoundTextProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0NvbXBvdW5kVGV4dFByb3BlcnRpZXMua3Q=) | `100.0% <ø> (ø)` | | | [...ore/engine/configuration/view/DividerProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0RpdmlkZXJQcm9wZXJ0aWVzLmt0) | `23.5% <ø> (ø)` | | | [...rcore/engine/configuration/view/ImageProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0ltYWdlUHJvcGVydGllcy5rdA==) | `34.6% <ø> (ø)` | | | [...ircore/engine/configuration/view/ListProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0xpc3RQcm9wZXJ0aWVzLmt0) | `83.3% <ø> (ø)` | | | [...ngine/configuration/view/PersonalDataProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L1BlcnNvbmFsRGF0YVByb3BlcnRpZXMua3Q=) | `0.0% <ø> (ø)` | | | [...hircore/engine/configuration/view/RowProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L1Jvd1Byb3BlcnRpZXMua3Q=) | `0.0% <ø> (ø)` | | | ... and [111 more](https://app.codecov.io/gh/opensrp/fhircore/pull/3045?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | | ... and [76 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3045/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)