opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
53 stars 41 forks source link

Fixes Measure Reporting functionality 🐛 #3058

Closed ndegwamartin closed 6 months ago

ndegwamartin commented 6 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3051

PR also includes:

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: 426 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (262eb3f) 29.9%. Report is 169 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3058 +/- ## ========================================== - Coverage 64.5% 29.9% -34.6% + Complexity 1075 650 -425 ========================================== Files 218 236 +18 Lines 9635 10923 +1288 Branches 1897 1896 -1 ========================================== - Hits 6218 3273 -2945 - Misses 2234 7229 +4995 + Partials 1183 421 -762 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.1% <61.4%> (-6.6%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (-17.1%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.3% <ø> (-53.6%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...martregister/fhircore/engine/OpenSrpApplication.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvT3BlblNycEFwcGxpY2F0aW9uLmt0) | `100.0% <100.0%> (ø)` | | | [...ter/fhircore/engine/configuration/Configuration.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uLmt0) | `25.0% <100.0%> (ø)` | | | [...ngine/configuration/event/EventTriggerCondition.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9ldmVudC9FdmVudFRyaWdnZXJDb25kaXRpb24ua3Q=) | `83.3% <ø> (+33.3%)` | :arrow_up: | | [...r/fhircore/engine/configuration/event/EventType.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9ldmVudC9FdmVudFR5cGUua3Q=) | `100.0% <ø> (ø)` | | | [...core/engine/configuration/view/ButtonProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0J1dHRvblByb3BlcnRpZXMua3Q=) | `86.2% <100.0%> (+32.9%)` | :arrow_up: | | [...core/engine/configuration/view/ColumnProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0NvbHVtblByb3BlcnRpZXMua3Q=) | `100.0% <ø> (ø)` | | | [...ngine/configuration/view/CompoundTextProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0NvbXBvdW5kVGV4dFByb3BlcnRpZXMua3Q=) | `100.0% <ø> (ø)` | | | [...ore/engine/configuration/view/DividerProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0RpdmlkZXJQcm9wZXJ0aWVzLmt0) | `88.8% <ø> (+65.3%)` | :arrow_up: | | [...rcore/engine/configuration/view/ImageProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0ltYWdlUHJvcGVydGllcy5rdA==) | `82.1% <ø> (+47.5%)` | :arrow_up: | | [...ircore/engine/configuration/view/ListProperties.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi92aWV3L0xpc3RQcm9wZXJ0aWVzLmt0) | `91.6% <ø> (+8.3%)` | :arrow_up: | | ... and [112 more](https://app.codecov.io/gh/opensrp/fhircore/pull/3058?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | | ... and [86 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3058/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)