search

opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
53 stars 41 forks source link

Refactor Sync status handling to migrate to CurrentSyncJobStatus #3059

Closed ndegwamartin closed 5 months ago

ndegwamartin commented 6 months ago

Describe the feature request. We need to migrate from using SyncJobStatus to using CurrentSyncJobStatus which has both work state and SyncJobStatus state representations.

Additional context This follows the upgrade SDK libraries PR https://github.com/opensrp/fhircore/pull/2825 changes

Acceptance criteria A check list of all things to verify once the implementation by the engineer is complete

Area path A list of ordered steps in the app on usage of the feature to support anyone testing it e.g. Code reviewer, QA e.g.

  1. Login to the app
  2. Open Navigation bar
  3. Click on Children register
  4. Click on Child profile
  5. Click on Edit profile from menu

Implementation plan (For Engineers) The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed. i.e. Describe how you intend to solve the problem

pld commented 6 months ago

Is this cleanup only or do we get a functional benefit from this change?

ndegwamartin commented 6 months ago

Is this cleanup only or do we get a functional benefit from this change?

This is related to the findings here https://github.com/opensrp/fhircore/issues/2942

ellykits commented 6 months ago

This should be code cleanup plus it will improve the sync notification UX.

ndegwamartin commented 5 months ago

Note: The issue https://github.com/opensrp/fhircore/issues/2942 is still blocked by https://github.com/google/android-fhir/issues/2472