opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
53 stars 41 forks source link

Test register screen composable #3062

Closed Raynafs closed 5 months ago

Raynafs commented 6 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 29.6%. Comparing base (ac82739) to head (145a962). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3062/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3062 +/- ## ======================================= Coverage 29.6% 29.6% Complexity 658 658 ======================================= Files 239 239 Lines 11204 11216 +12 Branches 1948 1950 +2 ======================================= + Hits 3323 3328 +5 - Misses 7447 7452 +5 - Partials 434 436 +2 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3062/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.1% <0.0%> (-0.1%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3062/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.4% <0.0%> (-0.1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3062?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...core/engine/ui/components/register/LoaderDialog.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdWkvY29tcG9uZW50cy9yZWdpc3Rlci9Mb2FkZXJEaWFsb2cua3Q=) | `0.0% <0.0%> (ø)` | | | [...e/quest/ui/register/components/RegisterCardList.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3JlZ2lzdGVyL2NvbXBvbmVudHMvUmVnaXN0ZXJDYXJkTGlzdC5rdA==) | `0.0% <0.0%> (ø)` | | | [...ister/fhircore/quest/ui/register/RegisterScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3JlZ2lzdGVyL1JlZ2lzdGVyU2NyZWVuLmt0) | `0.0% <0.0%> (ø)` | |
ellykits commented 5 months ago

It's interesting how codecov/patch is 0% here. Verify code coverage by running the jacoco test report gradle task locally.

Raynafs commented 5 months ago

It's interesting how codecov/patch is 0% here. Verify code coverage by running the jacoco test report gradle task locally.

Yes sure working on it,