opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
53 stars 41 forks source link

Make app title visibility configurable in LoginScreen #3063

Closed hamza-vd closed 6 months ago

hamza-vd commented 6 months ago

This PR will make app title visibility configurable in LoginScreen. This is something that was required for the mockup mentioned in this ticket

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (cd02814) 29.9%. Report is 171 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3063 +/- ## ========================================== - Coverage 64.5% 29.9% -34.6% + Complexity 1075 650 -425 ========================================== Files 218 236 +18 Lines 9635 10925 +1290 Branches 1897 1897 ========================================== - Hits 6218 3273 -2945 - Misses 2234 7231 +4997 + Partials 1183 421 -762 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.1% <ø> (-6.6%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (-17.1%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.3% <0.0%> (-53.6%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...artregister/fhircore/quest/ui/login/LoginScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xvZ2luL0xvZ2luU2NyZWVuLmt0) | `0.0% <0.0%> (-68.7%)` | :arrow_down: | ... and [126 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3063/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)