Closed ellykits closed 2 months ago
Attention: Patch coverage is 36.11111%
with 46 lines
in your changes missing coverage. Please review.
Project coverage is 28.3%. Comparing base (
ac82739
) to head (5a98047
). Report is 91 commits behind head on main.
This PR introduces a new configuration for unique ID assignments. Refer to the QuestionnaireConfig docs session to find out more. Here is a sample config:
{
"uniqueIdAssignment": {
"linkId": "phn",
"idFhirPathExpression": "Group.characteristic.where(exclude=false and code.text='phn').first().value.text",
"readOnly": false,
"resource": "Group",
"sortConfigs": [
{
"paramName": "_lastUpdated",
"dataType": "DATE",
"order": "DESCENDING"
}
],
"resourceFilterExpression": {
"conditionalFhirPathExpressions": [
"Group.active = true and Group.type = 'device' and Group.name = 'Unique IDs'"
],
"matchAll": true
}
}
}
@allan-on please add a top level feature for unique ID assignment here, https://docs.opensrp.io/features/app-features, then tag @rowo and me to review it
@allan-on I will add the remaining tests to improve the coverage during CHT this week.
@allan-on I will add the remaining tests to improve the coverage during CHT this week.
can add an issue that refs this pr?
Sure
Looks like testRetrieveUniqueIdAssignmentResourceShouldReturnAResource
is failing there's more coverage needed for retrieveUniqueIdAssignmentResource
, along with a couple other functions
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes 3048
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file