opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://opensrp.io
Apache License 2.0
55 stars 55 forks source link

Display data migration in settings #3079

Closed AbdulWahabMemon closed 2 months ago

AbdulWahabMemon commented 7 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.0%. Comparing base (83595aa) to head (f869d92). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3079 +/- ## ========================================= - Coverage 28.3% 28.0% -0.4% + Complexity 716 715 -1 ========================================= Files 266 265 -1 Lines 12760 12825 +65 Branches 2265 2304 +39 ========================================= - Hits 3621 3596 -25 - Misses 8666 8759 +93 + Partials 473 470 -3 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `64.9% <ø> (-0.1%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `12.8% <ø> (-7.0%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `4.7% <0.0%> (-0.1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3079?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...ircore/quest/ui/usersetting/UserSettingFragment.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3079?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fusersetting%2FUserSettingFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3VzZXJzZXR0aW5nL1VzZXJTZXR0aW5nRnJhZ21lbnQua3Q=) | `19.1% <0.0%> (-0.3%)` | :arrow_down: | | [...rcore/quest/ui/usersetting/UserSettingViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3079?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fusersetting%2FUserSettingViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3VzZXJzZXR0aW5nL1VzZXJTZXR0aW5nVmlld01vZGVsLmt0) | `4.2% <0.0%> (-0.2%)` | :arrow_down: | | [...fhircore/quest/ui/usersetting/UserSettingScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3079?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fusersetting%2FUserSettingScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3VzZXJzZXR0aW5nL1VzZXJTZXR0aW5nU2NyZWVuLmt0) | `2.2% <0.0%> (-0.1%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3079/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
ellykits commented 7 months ago

Is this PR read for review? @AbdulWahabMemon

AbdulWahabMemon commented 4 months ago

@ellykits your feedback is addressed, kindly re-review, app is also tested on stag with ecbisDebug,, app displays data-migration version 0 without any error or crash

cc: @ageryck