opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://opensrp.io
Apache License 2.0
55 stars 55 forks source link

Fixes config resources flagged for upsync 🐛 #3085

Closed ndegwamartin closed 7 months ago

ndegwamartin commented 7 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3076

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (4379852) 29.9%. Report is 175 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3085 +/- ## ========================================== - Coverage 64.5% 29.9% -34.7% + Complexity 1075 650 -425 ========================================== Files 218 236 +18 Lines 9635 10920 +1285 Branches 1897 1897 ========================================== - Hits 6218 3268 -2950 - Misses 2234 7231 +4997 + Partials 1183 421 -762 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.0% <76.9%> (-6.7%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (-17.1%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.3% <ø> (-53.6%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...hircore/engine/util/extension/ResourceExtension.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdXRpbC9leHRlbnNpb24vUmVzb3VyY2VFeHRlbnNpb24ua3Q=) | `65.6% <90.0%> (-4.3%)` | :arrow_down: | | [...core/engine/configuration/ConfigurationRegistry.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uUmVnaXN0cnkua3Q=) | `66.7% <33.3%> (-10.4%)` | :arrow_down: | ... and [125 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3085/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)