opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 41 forks source link

Fix setting related entity location on Group member and related resources #3092

Closed ellykits closed 5 months ago

ellykits commented 5 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (b8d1d3b) 29.8%. Report is 180 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3092 +/- ## ========================================== - Coverage 64.5% 29.8% -34.7% + Complexity 1075 652 -423 ========================================== Files 218 236 +18 Lines 9635 11059 +1424 Branches 1897 1925 +28 ========================================== - Hits 6218 3306 -2912 - Misses 2234 7323 +5089 + Partials 1183 430 -753 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.2% <100.0%> (-6.5%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (-17.1%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.3% <0.0%> (-53.7%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...ster/fhircore/engine/task/FhirCarePlanGenerator.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdGFzay9GaGlyQ2FyZVBsYW5HZW5lcmF0b3Iua3Q=) | `78.1% <100.0%> (+3.5%)` | :arrow_up: | | [...e/quest/ui/questionnaire/QuestionnaireViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3F1ZXN0aW9ubmFpcmUvUXVlc3Rpb25uYWlyZVZpZXdNb2RlbC5rdA==) | `3.5% <0.0%> (-69.7%)` | :arrow_down: | ... and [125 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3092/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)