opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 41 forks source link

Add Images against all widget on docs #3104

Closed brandy-kay closed 3 months ago

brandy-kay commented 4 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3095

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.9%. Comparing base (ac82739) to head (d124ba7). Report is 20 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3104 +/- ## ========================================= + Coverage 29.6% 29.9% +0.3% - Complexity 658 671 +13 ========================================= Files 239 239 Lines 11204 11211 +7 Branches 1948 1944 -4 ========================================= + Hits 3323 3359 +36 + Misses 7447 7415 -32 - Partials 434 437 +3 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `66.5% <ø> (+0.3%)` | :arrow_up: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.6% <ø> (+0.2%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3104/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
pld commented 4 months ago

@rowo or @HenryRae can you please take a look at these rendered docs and give input on the layout? thank you!

pld commented 4 months ago

@brandy-kay thanks for fixing the links! The images render now, we'll have design take a look and see if they have any feedback before we merge it in

HenryRae commented 4 months ago

@pld could you please show how image is currently rendered?

And more details on what we trying to solve/archive

pld commented 4 months ago

@HenryRae Roger said he showed you how to build the docs on your machine, any update on this?

rowo commented 4 months ago

@pld I don't know how to show @HenryRae how to build the docs on his machine as I had some issues getting the docs working on my new computer last week. So given that difficulty, I had to deprioritize it.

SebaMutuku commented 4 months ago

@HenryRae I can offer to show you how to build the docs. You can reach out whenever you are ready

HenryRae commented 4 months ago

I was able to setup docusaurus with @SebaMutuku help, not sure what next now. cc: @pld

pld commented 4 months ago

I was able to setup docusaurus with @SebaMutuku help, not sure what next now. cc: @pld

Great! Please take a look at the page engineering > android-app > configuring > config-types > widget, then sign-off on the layout there or request changes

pld commented 4 months ago

Specifically, please review the appearance of the images added on that page and if they look okay in terms of layout/aesthetics. If you would like anything changed, document it here. If it all looks okay, please sign off.

pld commented 3 months ago

@HenryRae is this good to go now?

HenryRae commented 3 months ago

@pld all looks good now