Closed brandyodhiambo closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 29.9%. Comparing base (
ac82739
) to head (d124ba7
). Report is 20 commits behind head on main.
@rowo or @HenryRae can you please take a look at these rendered docs and give input on the layout? thank you!
@brandy-kay thanks for fixing the links! The images render now, we'll have design take a look and see if they have any feedback before we merge it in
@pld could you please show how image is currently rendered?
And more details on what we trying to solve/archive
@HenryRae Roger said he showed you how to build the docs on your machine, any update on this?
@pld I don't know how to show @HenryRae how to build the docs on his machine as I had some issues getting the docs working on my new computer last week. So given that difficulty, I had to deprioritize it.
@HenryRae I can offer to show you how to build the docs. You can reach out whenever you are ready
I was able to setup docusaurus with @SebaMutuku help, not sure what next now. cc: @pld
I was able to setup docusaurus with @SebaMutuku help, not sure what next now. cc: @pld
Great! Please take a look at the page engineering > android-app > configuring > config-types > widget
, then sign-off on the layout there or request changes
Specifically, please review the appearance of the images added on that page and if they look okay in terms of layout/aesthetics. If you would like anything changed, document it here. If it all looks okay, please sign off.
@HenryRae is this good to go now?
@pld all looks good now
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3095
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file