opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Enhance Insight Screen UX #3195

Closed Raynafs closed 1 month ago

Raynafs commented 2 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3194

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 6.97674% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 29.3%. Comparing base (ac82739) to head (eda52e9). Report is 42 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3195 +/- ## ========================================= - Coverage 29.6% 29.3% -0.4% - Complexity 658 678 +20 ========================================= Files 239 248 +9 Lines 11204 11738 +534 Branches 1948 2055 +107 ========================================= + Hits 3323 3443 +120 - Misses 7447 7844 +397 - Partials 434 451 +17 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.6% <ø> (-0.6%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.4% <6.9%> (+<0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3195?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...e/quest/ui/usersetting/UserSettingInsightScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3195?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fusersetting%2FUserSettingInsightScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3VzZXJzZXR0aW5nL1VzZXJTZXR0aW5nSW5zaWdodFNjcmVlbi5rdA==) | `11.1% <6.9%> (+0.5%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3195/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
Raynafs commented 2 months ago

Image showing the implementation when the username is null. This case applies to even when the others return null. They will show -

image

Raynafs commented 2 months ago

image Possible implementation of all resources synced.

Raynafs commented 2 months ago

Video showing when all resources are synced and when we have unsynced resources

Screencast from 26-04-2024 08:54:34 ASUBUHI.webm

ellykits commented 1 month ago

Merging this. More UI tests can be added once instrumentation tests are re-activated to run on CI. For now the updated tests will suffice.