opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Apply register filter queries on nested search resources #3197

Closed ellykits closed 2 months ago

ellykits commented 2 months ago

This will allow filtering base resources using related resources.

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 30.1%. Comparing base (ac82739) to head (1739b80). Report is 28 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3197/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3197 +/- ## ========================================= + Coverage 29.6% 30.1% +0.4% - Complexity 658 672 +14 ========================================= Files 239 239 Lines 11204 11231 +27 Branches 1948 1953 +5 ========================================= + Hits 3323 3382 +59 + Misses 7447 7408 -39 - Partials 434 441 +7 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3197/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.6% <0.0%> (+0.2%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3197?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...er/fhircore/engine/util/extension/JsonExtension.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3197?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Futil%2Fextension%2FJsonExtension.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdXRpbC9leHRlbnNpb24vSnNvbkV4dGVuc2lvbi5rdA==) | `45.4% <ø> (ø)` | | | [...er/fhircore/quest/ui/register/RegisterViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3197?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fregister%2FRegisterViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3JlZ2lzdGVyL1JlZ2lzdGVyVmlld01vZGVsLmt0) | `0.0% <0.0%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3197/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)