opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Decode base64 data for images and provide bitmap data for remote image types #3202

Closed Lentumunai-Mark closed 1 month ago

Lentumunai-Mark commented 2 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Related to this issue

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 6.25000% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 30.0%. Comparing base (ac82739) to head (0730d1d). Report is 38 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3202/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3202 +/- ## ========================================= + Coverage 29.6% 30.0% +0.3% - Complexity 658 672 +14 ========================================= Files 239 240 +1 Lines 11204 11302 +98 Branches 1948 1971 +23 ========================================= + Hits 3323 3397 +74 - Misses 7447 7462 +15 - Partials 434 443 +9 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3202/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3202/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3202/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.6% <0.0%> (+0.2%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [.../fhircore/engine/util/extension/BitmapExtension.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Futil%2Fextension%2FBitmapExtension.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvdXRpbC9leHRlbnNpb24vQml0bWFwRXh0ZW5zaW9uLmt0) | `75.0% <100.0%> (+15.0%)` | :arrow_up: | | [...ister/fhircore/quest/ui/shared/components/Image.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fshared%2Fcomponents%2FImage.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3NoYXJlZC9jb21wb25lbnRzL0ltYWdlLmt0) | `0.0% <0.0%> (ø)` | | | [...ster/fhircore/quest/ui/profile/ProfileViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fprofile%2FProfileViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3Byb2ZpbGUvUHJvZmlsZVZpZXdNb2RlbC5rdA==) | `7.9% <0.0%> (-0.6%)` | :arrow_down: | | [...fhircore/quest/util/extensions/LoadRemoteImages.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3202?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Futil%2Fextensions%2FLoadRemoteImages.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3V0aWwvZXh0ZW5zaW9ucy9Mb2FkUmVtb3RlSW1hZ2VzLmt0) | `0.0% <0.0%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
Lentumunai-Mark commented 1 month ago

closing this in favor of https://github.com/opensrp/fhircore/pull/3242