fixes edit profile - questionItems disable via readOnlyLinkIds

AbdulWahabMemon commented 2 months ago

Revert fhircore PR#3069

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
[ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

ellykits commented 2 months ago

@ageryck @AbdulWahabMemon How is this PR different from this one by @DebbieArita https://github.com/opensrp/fhircore/pull/3070

ageryck commented 1 month ago

@ageryck @AbdulWahabMemon How is this PR different from this one by @DebbieArita #3070

@ellykits the other PR was evaluating to true when in edit mode irrespective of linkid's supplied hence rending full form in readonly mode @AbdulWahabMemon share more here

AbdulWahabMemon commented 1 month ago

@ageryck @AbdulWahabMemon How is this PR different from this one by @DebbieArita #3070

@ellykits the other PR was evaluating to true when in edit mode irrespective of linkid's supplied hence rending full form in readonly mode @AbdulWahabMemon share more here

https://github.com/opensrp/fhircore/pull/3218/files#r1590661089

opensrp / fhircore

fixes edit profile - questionItems disable via readOnlyLinkIds #3218