opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Change questionnaire button styling #3244

Closed LZRS closed 1 month ago

LZRS commented 1 month ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3212

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.0%. Comparing base (ac82739) to head (57bb972). Report is 40 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3244/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3244 +/- ## ========================================= + Coverage 29.6% 30.0% +0.3% - Complexity 658 678 +20 ========================================= Files 239 244 +5 Lines 11204 11424 +220 Branches 1948 1985 +37 ========================================= + Hits 3323 3429 +106 - Misses 7447 7547 +100 - Partials 434 448 +14 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3244/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.6% <ø> (-0.6%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `47.2% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. [see 7 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3244/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
ellykits commented 1 month ago

Can you share screenshots when these changes are applied and when they are not?

LZRS commented 1 month ago

Can you share screenshots when these changes are applied and when they are not?

Yeah, the screenshots are attached in the linked issue https://github.com/opensrp/fhircore/issues/3212