opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Fix navigation to Geowidget map on back press #3283

Closed aurangzaibumer closed 6 days ago

aurangzaibumer commented 1 month ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (ac82739) to head (1f9b043). Report is 105 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3283 +/- ## ========================================= - Coverage 29.6% 28.2% -1.4% - Complexity 658 720 +62 ========================================= Files 239 265 +26 Lines 11204 12711 +1507 Branches 1948 2261 +313 ========================================= + Hits 3323 3596 +273 - Misses 7447 8646 +1199 - Partials 434 469 +35 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.0% <ø> (-1.2%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `18.3% <ø> (-28.9%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `4.8% <0.0%> (-0.7%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3283?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...fhircore/quest/util/extensions/ConfigExtensions.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3283?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Futil%2Fextensions%2FConfigExtensions.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3V0aWwvZXh0ZW5zaW9ucy9Db25maWdFeHRlbnNpb25zLmt0) | `0.0% <0.0%> (ø)` | | ... and [40 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3283/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
aurangzaibumer commented 6 days ago

when launcherType is Map

https://github.com/opensrp/fhircore/assets/35099184/c2d24438-1ab4-4e45-9df4-7fb0771a86bf

aurangzaibumer commented 6 days ago

when launcherType is REGISTER

https://github.com/opensrp/fhircore/assets/35099184/86e118be-8841-4d13-bac8-1e418e8c4824