opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

search functionality for map fragment #3313

Open aurangzaibumer opened 3 weeks ago

aurangzaibumer commented 3 weeks ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/onaio/fhir-resources/issues/3255

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 13.63636% with 57 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (ac82739) to head (56e578c). Report is 106 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3313 +/- ## ========================================= - Coverage 29.6% 28.2% -1.4% - Complexity 658 727 +69 ========================================= Files 239 265 +26 Lines 11204 12754 +1550 Branches 1948 2266 +318 ========================================= + Hits 3323 3605 +282 - Misses 7447 8679 +1232 - Partials 434 470 +36 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.0% <0.0%> (-1.2%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `20.5% <52.9%> (-26.7%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `4.8% <0.0%> (-0.7%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...core/engine/domain/model/TopScreenSectionConfig.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Fdomain%2Fmodel%2FTopScreenSectionConfig.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvZG9tYWluL21vZGVsL1RvcFNjcmVlblNlY3Rpb25Db25maWcua3Q=) | `14.2% <0.0%> (ø)` | | | [...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fgeowidget%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fgeowidget%2Fscreens%2FGeoWidgetViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9nZW93aWRnZXQvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9nZW93aWRnZXQvc2NyZWVucy9HZW9XaWRnZXRWaWV3TW9kZWwua3Q=) | `94.4% <90.0%> (+7.7%)` | :arrow_up: | | [...ister/fhircore/quest/ui/register/RegisterScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fregister%2FRegisterScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL3JlZ2lzdGVyL1JlZ2lzdGVyU2NyZWVuLmt0) | `0.0% <0.0%> (ø)` | | | [...re/quest/ui/launcher/GeoWidgetLauncherViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flauncher%2FGeoWidgetLauncherViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xhdW5jaGVyL0dlb1dpZGdldExhdW5jaGVyVmlld01vZGVsLmt0) | `0.0% <0.0%> (ø)` | | | [...rcore/quest/ui/launcher/GeoWidgetLauncherScreen.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flauncher%2FGeoWidgetLauncherScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xhdW5jaGVyL0dlb1dpZGdldExhdW5jaGVyU2NyZWVuLmt0) | `0.0% <0.0%> (ø)` | | | [...ore/quest/ui/launcher/GeoWidgetLauncherFragment.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flauncher%2FGeoWidgetLauncherFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xhdW5jaGVyL0dlb1dpZGdldExhdW5jaGVyRnJhZ21lbnQua3Q=) | `0.0% <0.0%> (ø)` | | | [...er/fhircore/geowidget/screens/GeoWidgetFragment.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fgeowidget%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fgeowidget%2Fscreens%2FGeoWidgetFragment.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9nZW93aWRnZXQvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9nZW93aWRnZXQvc2NyZWVucy9HZW9XaWRnZXRGcmFnbWVudC5rdA==) | `0.5% <0.0%> (-0.3%)` | :arrow_down: | | [...rcore/quest/ui/main/components/TopScreenSection.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3313?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fmain%2Fcomponents%2FTopScreenSection.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL21haW4vY29tcG9uZW50cy9Ub3BTY3JlZW5TZWN0aW9uLmt0) | `0.0% <0.0%> (ø)` | | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3313/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
aurangzaibumer commented 3 weeks ago

@ellykits this is currently in WIP state/Not finalized.

aurangzaibumer commented 3 weeks ago

Updating few things before marking ready for review.

aurangzaibumer commented 3 weeks ago

@ellykits I have separated the shared search functionality part from this PR, this PR only contains search functionality done on the map fragment.

ellykits commented 2 weeks ago

Can you reference the issue on this PR @aurangzaibumer?

aurangzaibumer commented 2 weeks ago

Can you reference the issue on this PR @aurangzaibumer?

done, sir.

aurangzaibumer commented 4 days ago

Updating tests...