Refactor code

[ellykits]

IMPORTANT: Where possible all PRs must be linked to a Github issue

• Reuse existing code instead of implementing a new interface to retrieve the FHIR server URL.
• Delete unused code

Engineer Checklist

• [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
• [ ] I have added any strings visible on UI components to the strings.xml file
• [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
• [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
• [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
• [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

• [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
• [ ] I have verified any strings visible on UI components are in the strings.xml file
• [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
• [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
• [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 28.0%. Comparing base (ac82739) to head (d27980c). Report is 82 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3318 +/- ## ========================================= - Coverage 29.6% 28.0% -1.7% - Complexity 658 694 +36 ========================================= Files 239 265 +26 Lines 11204 12482 +1278 Branches 1948 2186 +238 ========================================= + Hits 3323 3501 +178 - Misses 7447 8520 +1073 - Partials 434 461 +27 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3318/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `64.7% <50.0%> (-1.5%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `18.7% <ø> (-28.5%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `5.2% <5.8%> (-0.3%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [...smartregister/fhircore/quest/QuestConfigService.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2FQuestConfigService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L1F1ZXN0Q29uZmlnU2VydmljZS5rdA==) | `0.0% <ø> (ø)` | | | [...tregister/fhircore/quest/ui/login/LoginActivity.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flogin%2FLoginActivity.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xvZ2luL0xvZ2luQWN0aXZpdHkua3Q=) | `6.5% <100.0%> (ø)` | | | [...g/smartregister/fhircore/quest/QuestApplication.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2FQuestApplication.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L1F1ZXN0QXBwbGljYXRpb24ua3Q=) | `0.0% <0.0%> (ø)` | | | [...er/fhircore/quest/ui/login/ConfigDownloadWorker.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flogin%2FConfigDownloadWorker.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xvZ2luL0NvbmZpZ0Rvd25sb2FkV29ya2VyLmt0) | `0.0% <0.0%> (ø)` | | | [...core/engine/configuration/ConfigurationRegistry.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fengine%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fengine%2Fconfiguration%2FConfigurationRegistry.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9lbmdpbmUvc3JjL21haW4vamF2YS9vcmcvc21hcnRyZWdpc3Rlci9maGlyY29yZS9lbmdpbmUvY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uUmVnaXN0cnkua3Q=) | `65.9% <50.0%> (-2.1%)` | :arrow_down: | | [...register/fhircore/quest/ui/login/LoginViewModel.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Flogin%2FLoginViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL2xvZ2luL0xvZ2luVmlld01vZGVsLmt0) | `1.6% <0.0%> (+<0.1%)` | :arrow_up: | | [...register/fhircore/quest/ui/main/AppMainActivity.kt](https://app.codecov.io/gh/opensrp/fhircore/pull/3318?src=pr&el=tree&filepath=android%2Fquest%2Fsrc%2Fmain%2Fjava%2Forg%2Fsmartregister%2Ffhircore%2Fquest%2Fui%2Fmain%2FAppMainActivity.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#diff-YW5kcm9pZC9xdWVzdC9zcmMvbWFpbi9qYXZhL29yZy9zbWFydHJlZ2lzdGVyL2ZoaXJjb3JlL3F1ZXN0L3VpL21haW4vQXBwTWFpbkFjdGl2aXR5Lmt0) | `1.4% <0.0%> (-1.1%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3318/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)