opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.
https://smartregister.org
Apache License 2.0
50 stars 39 forks source link

Initial Commit - Add strings.xml file to be used to override default values #3340

Open f-odhiambo opened 2 weeks ago

f-odhiambo commented 2 weeks ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

Code Reviewer Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.1%. Comparing base (ac82739) to head (78fc78a). Report is 105 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/graphs/tree.svg?width=650&height=150&src=pr&token=IJUTHZUGGH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)](https://app.codecov.io/gh/opensrp/fhircore/pull/3340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) ```diff @@ Coverage Diff @@ ## main #3340 +/- ## ========================================== + Coverage 29.6% 62.1% +32.4% + Complexity 658 651 -7 ========================================== Files 239 143 -96 Lines 11204 5204 -6000 Branches 1948 846 -1102 ========================================== - Hits 3323 3233 -90 + Misses 7447 1553 -5894 + Partials 434 418 -16 ``` | [Flag](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | Coverage Δ | | |---|---|---| | [engine](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `65.0% <ø> (-1.2%)` | :arrow_down: | | [geowidget](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `18.3% <ø> (-28.9%)` | :arrow_down: | | [quest](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp#carryforward-flags-in-the-pull-request-comment) to find out more. [see 118 files with indirect coverage changes](https://app.codecov.io/gh/opensrp/fhircore/pull/3340/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensrp)
f-odhiambo commented 1 week ago

Seems like this will be made configurable in the SDC https://github.com/google/android-fhir/pull/2571 DNM for now

dubdabasoduba commented 5 days ago

@ndegwamartin based on the translations convo should we do this for all our projects?

dubdabasoduba commented 5 days ago

@f-odhiambo for context. When doing translations, for it to be complete we also need to translate strings from the SDK.

The SDK might not allow us to update the language strings on its repo, hence the question of whether we want to copy everything for fhircore

cc: @pld

pld commented 4 days ago

What are the strings in the SDK that are not translated?