Transition experimental performance optimizations to FHIR Core

opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.

https://opensrp.io

Apache License 2.0

56 stars 59 forks source link

Transition experimental performance optimizations to FHIR Core #3358

Open ndegwamartin opened 4 months ago

ndegwamartin commented 4 months ago

Describe the Issue

[x] https://github.com/google/android-fhir/issues/2561
[x] https://github.com/google/android-fhir/issues/2559
[ ] Caching the Questionnaires and the corresponding StructureMaps - PR https://github.com/opensrp/fhircore/pull/3461
- Write back, can sync the first time they are used
- Write through, can we do the caching in the background? Could cache on Q/SM change, e.g. after initial sync, then first load will be faster
[x] #3439
[x] https://github.com/google/android-fhir/issues/2668
- [x] Parallelize any independent processing that happens after a search query e.g. when the SDK fetches the FHIR Resources from the DB they are returned as JSON documents. These need to be mapped to HAPI FHIR Structures which is a separate operation
[x] #3440
[x] https://github.com/google/android-fhir/issues/2531 When saving a questionnaire, run as single transaction, and not having to wait for other parts of related operations when queued in other transactions

pld commented 4 months ago

@ndegwamartin for the last one in this list, parallelization, do we have existing code that's implementing this? Can you share a link to this? Related, should we open an SDK issue for this or is this something that should live in the client (ie fhircore)

ndegwamartin commented 3 months ago

@ndegwamartin for the last one in this list, parallelization, do we have existing code that's implementing this? Can you share a link to this? Related, should we open an SDK issue for this or is this something that should live in the client (ie fhircore)

The code should reside on the SDK - The custom changes are bundled on this branch, they can be cherry. picked for PRs or discussions so that the SDK team can review first https://github.com/opensrp/android-fhir/tree/test-removed-select-transaction

pld commented 3 months ago

Cool, do we have an issue on Android FHIR SDK for that? On the Android FHIR SDK release we default to are we included the changes in that branch / should we be?

ndegwamartin commented 3 months ago

Cool, do we have an issue on Android FHIR SDK for that? On the Android FHIR SDK release we default to are we included the changes in that branch / should we be?

The latter is part of the focus of this ticket

pld commented 3 months ago

@ndegwamartin can you split infinite scroll into a new issue?

f-odhiambo commented 3 months ago

@LZRS @ndegwamartin Share an update here - Aug 5th

qiarie commented 2 months ago

@ndegwamartin @LZRS Should we consider adding a debounce interval to the register search if not already there?

ndegwamartin commented 2 months ago

@ndegwamartin @LZRS Should we consider adding a debounce interval to the register search if not already there?

Yeah we can explore this and evaluate its impact. Depending on the user patterns it may reduce the race conditions for the db connections as well as provide faster responses for users who enter more search characters. The latter may not be noticeable now though because of the scrolled pagination enhancement.