opensrp / fhircore

FHIR Core / OpenSRP 2 is a Kotlin application for delivering offline-capable, mobile-first healthcare project implementations from local community to national and international scale using FHIR and WHO Smart Guidelines on Android.

https://smartregister.org

Apache License 2.0

54 stars 41 forks source link

Known issues with Family registration #548

Closed maimoonak closed 2 years ago

maimoonak commented 3 years ago

Describe the bug Some known issues exist on Family Registration and ANC Flow which needs to be resolved

Issues

[x] 1- Thousands of records may need a proper filter when syncing (Discussion Point)
[x] 2- Questionnaire must have ONA as publisher OR may be any category as well for different apps (Discussion Point)
[x] 3- Use Practitioner and CareTeam reference when added by the server
[x] 4- Observation not binding to date only (SDK issue)
[x] 5- Sync failing due to some entity/record (Maimoona)
[x] 7- Implement SDK changes into data load for tags (Maimoona)
[x] 8- Add CarePlan based on activity detail of CarePlan (Maimoona)
[x] 9- Use vector instead of png https://github.com/opensrp/fhircore/pull/547#pullrequestreview-754886342 (Need images from Roger)
[x] 10- Remove run blocking from side menu count when functionality is implemented @ellykits

maimoonak commented 3 years ago

@ellykits I noticed the issue on sync is due to this line in engine -> FhirResourceConverter

return parser.parseResource(Bundle::class.java, value.string())

Basically the data after insert is the resource itself and not the bundle resource. Any reason it is casting to Bundle?

Screenshot from 2021-09-20 17-34-15

ndegwamartin commented 3 years ago

@maimoonak would casting to Resource type instead solve it without breaking the app?

maimoonak commented 3 years ago

I guess no! But SDK class src/main/java/com/google/android/fhir/reference/api/FhirConverter.kt does implementation of this.

maimoonak commented 3 years ago

7- Implement SDK changes into data load for tags (Maimoona) 8- Add careplan based on activity detail of Careplan (Maimoona)

Above would be resolved by #556

maimoonak commented 2 years ago

5 - Fixed in #618

ellykits commented 2 years ago

and 2. Are related to app configuration work tracked separately. Discussion available here https://github.com/opensrp/fhircore/discussions/594

maimoonak commented 2 years ago

-3 is partially done by adding organization to Patient when extracting resources. The rest would be done and accommodated into work done for #594

-4 only occurs when mapping observation via fhir-path which is unlikely and we use structure-map for extraction, so it can be ignored

pld commented 2 years ago

@maimoonak it appear these are all handled, if that's true please go ahead and close this issue