Closed machariamuguku closed 3 years ago
@rowo This might need a design review
@machariamuguku is there an easy way to view this in the site and a folder of the images I can access?
@rowo You've been given access to the images folder. I'm sharing the env file with you so you can clone and run this locally.
@rowo You've been given access to the images folder. I'm sharing the env file with you so you can clone and run this locally.
@machariamuguku please add a a screen recording or a snapshots of the page, so that they can be reviewed much quicker.
@rowo You've been given access to the images folder. I'm sharing the env file with you so you can clone and run this locally.
@machariamuguku please add a a screen recording or a snapshots of the page, so that they can be reviewed much quicker.
Before changes
After Changes
I could be wrong, but it looks like the new image for "Nutrition" seems to have its aspect ratio messed up. Could you fix that please, and investigate that it does not happen for the other two?
fixed
LGTM but let's let @rowo take a look
I will edit the image coloring
@machariamuguku On the MIECD site, are the images always in the ratio in the screenshot, https://github.com/OpenSRP/miecd/pull/20#issuecomment-818479684, or do they follow the width of the grey container behind it? I guess I’m wondering at narrow and wide browser widths, do they images look okay at their current ratio? I guess it doesn't matter if the images are all the same size and behave the same.
I will edit the image coloring
@machariamuguku On the MIECD site, are the images always in the ratio in the screenshot, #20 (comment), or do they follow the width of the grey container behind it? I guess I’m wondering at narrow and wide browser widths, do they images look okay at their current ratio? I guess it doesn't matter if the images are all the same size and behave the same.
They scale linearly, following the width of the container at a ratio. They always fit the container without stretching
@machariamuguku here are some images where I matched the nutrition image to same ratio as the other two and tried to normalize the color. In my opinion, it would look better to put the images within the container now that they are full-bleed photos and not cutout illustrations, but I understand if that's not possible for the project.
In my opinion, it would look better to put the images within the container now that they are full-bleed photos and not cutout illustrations
@rowo I could try that.
Are you thinking more of this
or this?
@rowo In hindsight, due to timelines, I think we can schedule these changes for the future
I think we can schedule these changes for the future
@machariamuguku could you add an issue for this?
Fixes #7