search

opensrp / openmrs-module-cohort

2 stars 8 forks source link

Add Cohort role, Program, Member Attributes Type, Attributes Type, Cohort Type- No character limit is available on Enter Role Name field #15

Open zohaibihs opened 8 years ago

zohaibihs commented 8 years ago

Add Cohort role - No character limit is available on Enter Role Name field (There should be a character limit of 20 characters on text fields).

bholagabbar commented 8 years ago

Text limit is 255 characters as discussed with @maimoonak. Please tell me if it to be changes. Closed similar tickets and clubbed into one

zohaibihs commented 8 years ago

It need to be change as 255 characters for text fields is too much, like 20 characters should be allowed because it is not a text box to accept 255 characters.

bholagabbar commented 8 years ago

@maimoonak You said 20 was too less. What should the new limit be is 255 is too much?

maimoonak commented 8 years ago

I would say it should be more than 100. 100-150 is a safe limit.

bholagabbar commented 8 years ago

Should we keep 120 then

On 09-Aug-2016 1:02 PM, "maimoonak" notifications@github.com wrote:

I would say it should be more than 100. 100-150 is a safe limit.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/openmrs-module-cohort/issues/15#issuecomment-238475911, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJuG04gONJQe6FtF6VREdSwQRTYQjDZks5qeC0KgaJpZM4JafWZ .

zohaibihs commented 8 years ago

As per discussion with Maimoona, it should be 100 characters.

bholagabbar commented 8 years ago

@maimoonak I'm not able to determine where I should be making the changes. Could you help me out? Which file(s) needs to be modified. I'm pretty sure it's not liquibase.xml. Is it in the hibernate mappings?

maimoonak commented 8 years ago

Is this constraint implemented on DB level? If you cant find it in liquibase and hbms then I think its just on UI level. I would suggest to keep it as it is on DB level and donot make any change to default string len which is 255 chars! Just implement in Validator in Controller to limit input to 100 characters. You can also limit by adding size or maxlen attribute of html on control itself.

bholagabbar commented 8 years ago

Ok I will make the change in the HTML form

bholagabbar commented 8 years ago

Fixed in commit https://github.com/OpenSRP/openmrs-module-cohort/commit/b2f930448046f10ac1d896bef281939b668e77e6 . Also, hope we can close the issues with tags 'resolved' soon

maimoonak commented 8 years ago

Yeh. You can mark all resolved issues with tag 'resolved'. QA team would Close the issue after confirmation in next release

zohaibihs commented 8 years ago

Cohort member role - No character limit is available on Enter Role Name field (There should be a character limit of 100 characters on text fields).

bholagabbar commented 8 years ago

@zohaibihs just issues a commit which fixes that 7bae54e61dae10e63c5d611c6c0773d2ff037c74

zohaibihs commented 8 years ago

Yes, I have seeing your code but its not working fine on front end. Cohort member role - No character limit is available on Enter Role Name field.

image

bholagabbar commented 8 years ago

I JUST issued it. It's fixes If you recompile the module

On 19-Aug-2016 3:57 PM, "zohaibihs" notifications@github.com wrote:

Yes, I have seeing your code but its not working fine on front end. Cohort member role - No character limit is available on Enter Role Name field.

[image: image] https://cloud.githubusercontent.com/assets/20788534/17806958/0af57dcc-6621-11e6-88be-73930be8fa3c.png

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/openmrs-module-cohort/issues/15#issuecomment-240983923, or mute the thread https://github.com/notifications/unsubscribe-auth/ALJuG70zjqPbG-cOtmnusU19ezjf41PCks5qhYUjgaJpZM4JafWZ .