Code Review - API

[maimoonak]

Boolean isRetired should b removed from POJO, hbm.xml, and liquibase from classes inheriting BaseOpenmrsData since the class already has a field voided to represent retired status. Such classes are:

• [x] Team
• [x] TeamHierarchy
• [x] TeamMember

String uuid should be removed fom POJO, hbm.xml as this is inherited by BaseOpenmrsData, hence available in all classes extending it. Classes duplicating uuid are:

• [x] Team

• [x] TeamHierarchy

• [x] TeamLog

• [x] TeamMember

• [ ] Team Hierarchy should reference teamRole rather than having teamRoleId inside. Also teamHierarchy should have a primary key teamHierarchyId

• [ ] TeamHierarchy doesnot have schema as discussed and defined in wiki. In hierarchy teamRole reportTo other teamRole not to teamMember.. (critical)

• [x] TeamLog doesnot have dataOld property

• [x] TeamMember doesnot match the documented schema and design, and still have duplicate properties (critical)

• [x] TeamMemberLog still have duplicate properties related to auditInfo

• [x] TeamMemberPatientRelation have duplicate properties related to auditInfo

• [x] property naming is not consistent thoughout classes. e.g. member should be teamMember, assignmentDate should b dateAssigned (analogus to dateCreated), teamMemberPatientId should be teamMemberPatientRelationId

• [x] TeamMemberService has a long list of methods and half of these are not required

[maimoonak]

• [x] pageIndex is not right name for limit start property. Use start/offset/startRecord etc
• [x] maxResults should not be hardcoded
• [x] TeamHierarchyDAO should not have getAllTeams method name
• [x] TeamMemberDAO have a lot of methods and alot of processing logic. This should be refactored and simplified
• [x] getTeamPatientRelations and getTeamPatientRelations in TeamPatientRelationsDAO doesnot have correct logic, and params