search

opensrp / opensrp-client-chw

Reference OpenSRP application for Community Health Workers (CHWs)
Other
3 stars 21 forks source link

Add a scroll to the client profile #1028

Open msschroeder opened 4 years ago

msschroeder commented 4 years ago

The client profile is becoming quite long and some values are no longer visible on the device screen. We will need to add a scroll to the client profile to allow the user to view all part (top to bottom)

@rowo Is there any design aspects we should consider for such a feature?

rowo commented 4 years ago

@msschroeder can you kindly share a screenshot of the problem?

msschroeder commented 4 years ago

Screenshot_20191206-091735

@roow Here is an example of when the profile is a family head or caregiver

rowo commented 4 years ago

Ok thanks @msschroeder. There are a few things to comment on here:

  1. yes this profile view needs a scroll. Ideally it could work the same as the ANC app where when a user scrolls up, the top section gets squished down so only the client name appears in the section below the back button row.
  2. I think I need to provide a better avatar with a colored background.
  3. There's a lot of margin after MLEZI. This should be the same space as between the color break and the red overdue button.
  4. The red overdue button has a lot of text. Is there a way to shorten this?
  5. The sections below also have a lot of text. Is there a way to shorten this?
  6. The family due section should be left aligned.
msschroeder commented 4 years ago

@rowo Feedback on your comments:

  1. yes this profile view needs a scroll. Ideally it could work the same as the ANC app where when a user scrolls up, the top section gets squished down so only the client name appears in the section below the back button row. - That would be fine for me 2. I think I need to provide a better avatar with a colored background. - Would it be possible to get a mock up or idea of what this would look like?
  2. There's a lot of margin after MLEZI. This should be the same space as between the color break and the red overdue button. @manutarus What is the margin for a user profile when they are either the head of household or primary caregiver? It is quite large. 4. The red overdue button has a lot of text. Is there a way to shorten this? 5.The sections below also have a lot of text. Is there a way to shorten this? - The Swahili version is sometimes very long. And to not lose the meaning it is not always possible. The Jphiego team is aware of this, but it might forget as they are translating sometimes. We raised it as we were reviewing in September. However, they are continuously adding to Transifex. Also, it is not always easy to know where the text goes to and there are duplicates of the same text. So the only way to know what it relates to is once you see it. I guess the best way forward is I can talk to Jphiego and see if they can review them again and try and shorten them.
rowo commented 4 years ago

@msschroeder Thanks.

  1. Cool, let's go with that. Let me know if I need to do anything.
  2. Not too different. I think it's just fading into the background too much. See here: Screen Shot 2020-01-05 at 10 34 07 PM

    4-5. Shorter text — gotcha. yeah I think here would be a situation to follow up with them. It should be useful, but this space doesn't let you communicate everything, so it's a balance about what needs to be highlighted if the straight translation is so long.

manutarus commented 4 years ago

@msschroeder @rowo Yes moving the profile to a collapsing toolbar layout would be nice, the margin after MLEZI gets used up if the member is a family head or/and primary caregiver but we can reduce this when not required.

msschroeder commented 4 years ago

@ellykits Is this done? Has it been merged?