Closed cafootitt closed 3 years ago
@cafootitt For C could you direct me to the assets?
@rowo Can you add these icons to the assets in Marvel handoff, or just post them to this issue?
@bennsimon @cafootitt Here are the icons:
@bennsimon For D, how are you making that graphic word for all screen sizes? Would it make more sense to do the border in Android itself? Or if that's too troublesome, we can move away from their styling and do something easier to scale to different proportions.
@rowo i can scale the default image to fit the entire screen. But for the actual images am thinking we let the image fit on the given height since different images might have different dimensions.
Its okay to work with the default image the way it is since its the only one with a border.
A textView however can scale easily.
@bennsimon Okay, thanks on the default image.
On user-provided images it would be ideal if it can fit within the width or height (as max), but height-only is probably the next best guessing what kind of images they'll upload. Is it possible for the user to drag-zoom the image easily (sometimes happens in news apps as an easier way than a fullscreen image viewer)? That would be another nice to have but not needed right now.
@rowo For the
@bennsimon @cafootitt Here are the icons:
@bennsimon For D, how are you making that graphic word for all screen sizes? Would it make more sense to do the border in Android itself? Or if that's too troublesome, we can move away from their styling and do something easier to scale to different proportions.
@rowo Can we have this icons be of the same size. If possible can have them in (vector) .svg format.
@bennsimon I slack dm'd you the svg's
16 Dec 2020 build - looks great, good work!