Open rowo opened 6 years ago
@rowo Thanks for this. I made some comments in the issue above. For the wording on BCG 2, I think that's fine for now. I think having the service reminder appear in the vaccine card next would make sense (BCG 2). The expiration on this would be 1 year, and I assume making it overdue after 10 days would also be ok.
One suggestion is that we might not be able to allow edits, so a "back" button on the confirmation window or something that takes them back to the first question might be a good idea.
Here are two approaches to incorporate a back or undo:
Seems like this is the more traditional way of providing an undo option on an Android device.
Following material guidelines, I had to change the wording a bit when adding the "go back" option.
I think I prefer the 2nd option, because for this we can require the user to make a selection (by making the outside area untappable), which might prevent accidental data entry. We discussed previously that BCG 2 happens at 12 weeks, so instead of creating a new 12-weeks grouping on the vaccine card, we would put BCG 2 reminder next to BCG in the birth grouping.
@paulnindi What is your feedback?
@hallix Assigning you for now, as this is a new feature issue that we think would be great for you to work on. Roger will post final mockups when they're done.
@cagulas I side with you. Second option looks more appealing and its a good idea to have the reminder appearing on the birth grouping
oh sorry mistakenly closed.. :)
@paulnindi :D
@cagulas So final mockups just means the BCG reminder in the birth group? Did you discuss any other changes on the call or with Paul?
Correct, no other changes were discussed.
Change the current BCG dialog:
To a larger dialog that is in a question format:
We will not allow the user to tap outside the 2nd dialog (Turn off BCG reminder and Create BCG reminder) to close it. User can tap outside the 1st dialog, which is the same as hitting dismiss.
Let's make the reminder say "Turn off check BCG scar reminder" instead.
OpenMRS concept to use:
ID: 160265 Label: BCG scar present on examination Datatype: Coded Answer choices: Yes, No, Unknown
After discussing with @rowo, let's create a new box for the BCG scar with date that scar was confirmed, e.g. "BCG scar 21/2/2018".
So in summary, every child would eventually have 3 boxes in the birth group, OPV 0, BCG, and either BCG scar or BCG 2.
This issue should be ready to implement now. Let me or Roger know if there are any questions.
The birth group isn't updated with the third box - BCG scar, if I confirm that the child has a scar.
Results from 13 April release QA:
Still need to test the syncing to OpenMRS and the scheduling of this service.
Lgtm
The parent vaccine concept for BCG 2 is not appearing in OMRS though.
PATH team has proposed to change the BCG scar reminder into a yes/no question on whether BCG scar is present. If present, reminder doesn’t appear again. If not present,
keep reminding until BCG 2 dose is recordedBCG 2 dose should become due.Further notes/questions:
Popup update
Popup if answer Yes
Popup if answer No