opensrp / opensrp-client-tbr

Other
2 stars 4 forks source link

Add sort, filter screens #45

Open cafootitt opened 6 years ago

cafootitt commented 6 years ago

This issue is blocked, as we're waiting on content/parameters from IHS.

kwasim commented 6 years ago

Ali's response:

Filters for different types of positive results definitely useful in positive and in-treatment registers (based on last recorded result)

smear +ve Xpert +ve RIF resistant Culture +ve Xray indicative

We should definitely only allow filtering on register content. That is a reasonable and logical constraint

Other filters (for appropriate registers)

Presumptive but not diagnosed for 1 week Positive but not started treatment for 1 week Anyone with an overdue follow-up or missed smear

Sorting: Name, encounter date, encounter location I think that should be enough to get started and then we can get feedback during the pilot.

cafootitt commented 6 years ago

@kwasim Great, thanks. I'll pass this over to Roger now for mocking up.

For the Sorting, I assume you meant "name, encounter location and encounter date" (instead of saying encounter location twice)?

kwasim commented 6 years ago

yup that's encounter date

On Thu, Jan 11, 2018 at 3:15 PM, Carolyn Gulas notifications@github.com wrote:

@kwasim https://github.com/kwasim Great, thanks. I'll pass this over to Roger now for mocking up.

For the Sorting, I assume you meant "name, encounter location and encounter date" (instead of saying encounter location twice)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/45#issuecomment-356889218, or mute the thread https://github.com/notifications/unsubscribe-auth/AKksl_AUVI61j7y-st01twEEFW1qZ5sFks5tJd9MgaJpZM4Q5Ky7 .

-- Wasim Khan Software Development Manager Interactive Health Solutions www.ihsinformatics.com

Ph: +92 302 2564278 Skype: wasim.khan.ihsinformatics wasim.khan@ihsinformatics.com

rowo commented 6 years ago

@kwasim For "We should definitely only allow filtering on register content. That is a reasonable and logical constraint", do you mean register content as in what's showing up in the list or all of the content in the app?

If it's the first, I think we can look into it, but maybe it's not worth the time to enforce that this must always be the case. For example maybe an app only shows Xpert results, but not full results, in the register. But we have filtering by any positive results in general, perhaps. So if you filter by positive smears, you won't see that result in each row of the list. Seems okay to me to allow someone to filter on smear results here (if smear result exist) if the user wants rather than have checks to prevent stuff like that.

rowo commented 6 years ago

@cagulas Also how does advanced search work here? Are there multiple locations (our of area) or do we kind of just search one large list with the extra parameters above in addition to demographic data?

cafootitt commented 6 years ago

I'll ask in the meeting notes document

rowo commented 6 years ago

Also when it says "name" does the form differentiate between first and last name?

alihabib commented 6 years ago

@rowo

@kwasim For "We should definitely only allow filtering on register content. That is a reasonable and logical constraint", do you mean register content as in what's showing up in the list or all of the content in the app?

Wasim passed on what I had written, which I should have been clearer about. I meant to say that we should only allow filtering on anything that is a selectable variable in the registers (even if it is not visible in the registers). So basically users should be able to filter on things that are in the universe of available variables (visible on register or not) but not on custom questions that they add to XLS Forms themselves.

Hope that helps clarify it

Ali

alihabib commented 6 years ago

@rowo

@cagulas Also how does advanced search work here? Are there multiple locations (our of area) or do we kind of just search one large list with the extra parameters above in addition to demographic data?

This would be a project-wide search (as opposed to a location specific search).

Ali

rowo commented 6 years ago

@kwasim @alihabib For filters, is it determined by the following?

Presumptive but not diagnosed for 1 week

= Encounter date is 7+ days before today

Positive but not started treatment for 1 week

= Diagnosis date is 7+ days before today

alihabib commented 6 years ago

Hi,

Yep. Both those are correct

Ali

Ali Habib Chief Executive Officer Interactive Health Solutions http://www.ihsinformatics.com

ali.habib@ihsinformatics.com

On Thu, Jan 18, 2018 at 12:46 PM, Roger W. notifications@github.com wrote:

@kwasim https://github.com/kwasim @alihabib https://github.com/alihabib For filters, is it determined by the following?

Presumptive but not diagnosed for 1 week = Encounter date is 7+ days before today

Positive but not started treatment for 1 week = Diagnosis date is 7+ days before today

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/45#issuecomment-358564689, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKhwFISRusOV1hoOHKbeUEgABFfsBks5tLvbtgaJpZM4Q5Ky7 .

kwasim commented 6 years ago

Possible advanced search parameters:

Participant ID* ,variable: participant_id, form: Screening form, TI form, Add-In-Treatment form, FUP form, Diagnosis form, Treatment Outcome form, Contact Screening, Add-Positive-Patient, Remove Patient, actually in all the forms.

First name ,variable: first_name, form:Screening, TI form, Add-In-Treatment, Add-Positive-Patient Last name ,variable: last_name, form:Screening, TI form, Add-In-Treatment, Add-Positive-Patient Gender ,variable: gender, form:Screening, TI form, Add-In-Treatment, Add-Positive-Patient Age group --> possible options: 0-15, 16-30, 31-45, 46-60, 61-75, 76-119 variable: age, form: Screening, TI form, Add-In-Treatment, Add-Positive-Patient Phone number ,variable: contact_phone_number, form:Screening, Add-In-Treatment, Add-Positive-Patient National ID ,variable: national_id, form:Screening, Add-In-Treatment, Add-Positive-Patient Umme will create the national ID variable

rowo commented 6 years ago

Sort and filter settings accessible via dropdown menu: filterandsort01

Sort and filter options. Sort is a dropdown select one that defaults to Name. The rest are filters that will show results that match what is selected. I added a "No results" option there as an idea, but we can remove it for project or technical reasons. CG: Updated screens

Sort menu would be the following two options:

If a filter is active, the black notification box appears at the bottom of the register list. This notification will show up whenever a user returns to the register list view that has filters applied and will time out after 5 seconds or possibly if the user starts scrolling (if straightforward/easy to do). filterandsort03 Note: The wording of the filters in the above screen should be updated to match the filter wording in the sort/filter screens above. Side note: I'm going to move advanced search to another issue.

cafootitt commented 6 years ago

@kwasim Since the user doesn't ever select an encounter location in any of the forms (it is pre-populated I assume based on their team assignment), we will remove the encounter location from the sort, as this wouldn't add any value if they are all the same encounter location.

Also, @kwasim @alihabib Any feedback on the above mockups? Any specific wording we should use or change?

kwasim commented 6 years ago

makes sense!

On Mon, Jan 22, 2018 at 7:04 PM, Carolyn Gulas notifications@github.com wrote:

@kwasim https://github.com/kwasim Since the user doesn't ever select an encounter location in any of the forms (it is pre-populated I assume based on their team assignment), we will remove the encounter location from the sort, as this wouldn't add any value if they are all the same encounter location.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/45#issuecomment-359432223, or mute the thread https://github.com/notifications/unsubscribe-auth/AKksl169tqrhW-01P3JaSuoC9lp3SlPBks5tNJV4gaJpZM4Q5Ky7 .

-- Wasim Khan Software Development Manager Interactive Health Solutions www.ihsinformatics.com

Ph: +92 302 2564278 Skype: wasim.khan.ihsinformatics wasim.khan@ihsinformatics.com

cafootitt commented 6 years ago

@kwasim @alihabib for Smear positive in the sort menu, does this include 3+, 2+, 1+ and scanty (classified together as positive) and negative would be the only answer choice classified as negative and left out of the filter?

alihabib commented 6 years ago

Hi,

Yep that is correct.

Ali

-- Sent from my mobile. Please excuse typos and brevity

On 23-Jan-2018 17:30, "Carolyn Gulas" notifications@github.com wrote:

@kwasim https://github.com/kwasim @alihabib https://github.com/alihabib for Smear positive in the sort menu, does this include 3+, 2+, 1+ and scanty (classified together as positive) and negative would be the only answer choice classified as negative and left out of the filter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/45#issuecomment-359776222, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKghpyRt8-3zmQttRVRkp-yrSqCk2ks5tNdD4gaJpZM4Q5Ky7 .