opensrp / opensrp-client-tbr

Other
2 stars 4 forks source link

Update details views to show pos and neg results #48

Closed cafootitt closed 6 years ago

cafootitt commented 6 years ago

For presumptive and positive registers, the detail views should show both pos and neg results.

rowo commented 6 years ago

@cagulas In the meeting, did you talk about the "results comparison" box in in-treatment details view? I think it'd be useful as a way to show baseline vs. recent results. CG: Yea, there are no changes needed for in-treatment results box. The baseline vs. current looks good as is. Also, is the content of positive results during in-treatment finalized? Instead of first encounter date, it highlights the treatment start date. CG: Yea, this is fine. The latest results at the point of treatment initiation will be considered baseline results. Although, similar to presumptive and positive registers, I think even negative results would be useful to show, as in, they might not count on tests that were negative from the start as a marker of progress.

Presumptive and Positive detail results box:

tb-presumptive-positive

In-treatment detail results box options:

tb-in-treatment

cafootitt commented 6 years ago

For the presumptive and positive, I would remove "positive" from "no positive results recorded" because this is now showing all results.

The results comparison for the in-treatment looks good. I think it should show even negative results at the baseline as well.

rowo commented 6 years ago

@cagulas Thanks, here are updated screens. Added dates and month of treatement to positive results box as well since that will only be used during in-treatment.

Presumptive and positive results: results01

In treatment results:

results-intreatment

cafootitt commented 6 years ago

@rowo This looks good, but I'm not sure what the "Positive Results" box is for? Wouldn't only the "Results Comparison" box need to be shown in the in-treatment register?

rowo commented 6 years ago

@cagulas It is for if people don't want to show the results comparison in case that ever happens. So they represent two configurable options. We could just say for that in-treatment, it only shows the comparison — that's definitely an option.

cafootitt commented 6 years ago

I think it wouldn't happen to only look at positive results. Because they compare progress to baseline always to see if they're getting better. If they aren't improving from baseline, they might have to do additional tests (like for MDR-TB) or switch medications. I think we're ok with only doing the comparison. Does that sound ok?

rowo commented 6 years ago

I get why comparison is important and how that all works. I did originally propose the combined view after all. I'd also love to do a chart version if we ever get to a v2. Maybe a single result mapped over time since the tests done are more limited during treatment.

Providing an alternate view is more about if due to constraints or workflow, the positive results is all they have and you don't want to force someone to make up baseline results or something bad like that. So if that's never going to be a possibility or too much of an edge case, we can get rid of it and force the comparison view. Alternatively, another way to handle that is by showing a case where baseline results don't exist (for whatever reason), but you show the earliest result taken. I don't know how this impacts the form. But in that case, the label would change from Baseline Results to maybe Earliest Results or something.

cafootitt commented 6 years ago

I can't think of a situation where baseline results wouldn't exist in the app. They wouldn't start treatment without baseline results entered. If they transfer in from another place and don't have their baseline results with them, they'd test them again, and they'd use those as the baseline results (if they can't get the original results).

rowo commented 6 years ago

Ok no positive results sounds good if that's the only workflow. I updated the screen above.

cafootitt commented 6 years ago

Closing this issue. Created https://github.com/OpenSRP/opensrp-client-tbr/issues/57 and https://github.com/OpenSRP/opensrp-client-tbr/issues/56 for implementation.