opensrp / opensrp-client-tbr

Other
2 stars 4 forks source link

Update Xpert results in configurable columns #52

Closed cafootitt closed 6 years ago

cafootitt commented 6 years ago

I think it would be helpful to show the different options for Xpert results in the configurable column, because I think there might be a spacing issue, so hopefully you can tell us.

I'm referring to comments from Wasim in https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569.

Note 1: RIF result is only recorded if MTB is detected (+ve). So, if MTB result is any other answer choice above, then RIF result should not be displayed in the column (and the MTB result can be the full width of the column).

Note 2: If error is selected (err), the error code should also be displayed. According to Wasim, the error code is usually four digits and can be displayed in parentheses.

Note 3: Again, these are only displayed if MTB result is detected (+ve).

Note 4: There is no error code collected for RIF result in the form, so this would just be "err" alone. CG: Error for RIF was removed in the XLSForm it looks like.

@alihabib and @kwasim Does the above sound ok to you. I am basing this off the latest xlsform for Xpert result uploaded to Ona.

alihabib commented 6 years ago

This all looks good. If we can have "err" instead of "e" for error I think that would be more clear.

Ali

Ali Habib Chief Executive Officer Interactive Health Solutions http://www.ihsinformatics.com

ali.habib@ihsinformatics.com

On Fri, Dec 15, 2017 at 1:20 PM, Carolyn Gulas notifications@github.com wrote:

I think it would be helpful to show the different options for Xpert results in the configurable column, because I think there might be a spacing issue, so hopefully you can tell us.

I'm referring to comments from Wasim in #34 (comment) https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569 .

  • In the Xpert result form, the MTB result answer choices (and the suggested label for the configurable column in parentheses) are:
  • detected (+ve)
  • not_detected (-ve)
  • indeterminate (?)
  • error (e)
  • no_result (No result)

Note 1: RIF result is only recorded if MTB is detected (+ve). So, if MTB result is any other answer choice above, then RIF result should not be displayed in the column (and the MTB result can be the full width of the column).

Note 2: If error is selected (e), the error code should also be displayed. According to Wasim, the error code is usually four digits and can be displayed in parentheses.

  • The RIF result answer choices (and the suggested label for the configurable column in parentheses) are:
  • detected (+ve)
  • not_detected (-ve)
  • indeterminate (?)
  • error (e)

Note 3: Again, these are only displayed if MTB result is detected (+ve).

Note 4: There is no error code collected for RIF result in the form, so this would just be "e" alone.

@alihabib https://github.com/alihabib and @kwasim https://github.com/kwasim Does the above sound ok to you. I am basing this off the latest xlsform for Xpert result uploaded to Ona.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/52, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKsd-jnUotxHZb4Ff_I1rAAFBMR7uks5tAiu7gaJpZM4RDJp- .

cafootitt commented 6 years ago

Thanks @alihabib, I updated the issue.

rowo commented 6 years ago

xpertresults

Here's a look at what Xpert results might look like in an Xpert results-only column and in the results column Xpe line. The description in the first comment covers how to determine what shows up, so I tried just to illustrate the extreme cases — and there doesn't seem to be a spacing issue except potentially No result and error codes, but those can break to the second line if needed.

Also note +ve will always show up in #c30000 to highlight the positive result whether it's MTB or RIF. Otherwise, negative and other results show up in #191919 and the MTB, RIF and Xpe show up in #737373.

cafootitt commented 6 years ago

Looks great, thanks @rowo. Changing this to an implementation issue now and assigning @githengi and @ndegwamartin. Please note how the results are shown differently in Xpert result only column vs. the general results column.

githengi commented 6 years ago

@cagulas @rowo When is "No Result" to be displayed

rowo commented 6 years ago

@githengi I took it to mean that there is a "No result" choice in the Xpert result form for MTB result.

alihabib commented 6 years ago

@Roger: That's right. "No Result" can be the outcome of an Xpert test

Ali

Ali Habib Chief Executive Officer Interactive Health Solutions http://www.ihsinformatics.com

ali.habib@ihsinformatics.com

On Thu, Jan 11, 2018 at 7:44 PM, Roger W. notifications@github.com wrote:

@githengi https://github.com/githengi I took it to mean that there is a "No result" choice in the Xpert result form for MTB result.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/52#issuecomment-356954611, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKnH7leyNbgxu7qH5R_b5fvMENmgCks5tJh5ZgaJpZM4RDJp- .

githengi commented 6 years ago

@alihabib could the "No Result" outcome kindly be added to the current GeneXpert Enketo form

cafootitt commented 6 years ago

@u-moosajee @kwasim The no result is already there, but the list name is missing in the xlsform, which means this option is not showing up right now. Umme, can you please fix this?

u-moosajee commented 6 years ago

@cagulas ive fixed it and updated the form

cafootitt commented 6 years ago

Lgtm, closing.