opensrp / opensrp-client-tbr

Other
2 stars 4 forks source link

Update Smear results in configurable columns #53

Closed cafootitt closed 6 years ago

cafootitt commented 6 years ago

I think it would be helpful to show the different options for Smear results in the configurable column, because there might be a spacing issue, so hopefully you can tell us.

I'm referring to comments from Wasim in https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569.

Note 1: Wasim suggested in https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569 to use "Sty" for scanty and "Neg" for negative, but since this is the only result shown, I think we can show the full word.

Note 2: All answer choices except negative are red font, while negative would be black font.

alihabib commented 6 years ago

If Negative is too long "-" will also work. I'd say leave scanty red as well

Ali Habib Chief Executive Officer Interactive Health Solutions http://www.ihsinformatics.com

ali.habib@ihsinformatics.com

On Fri, Dec 15, 2017 at 1:30 PM, Carolyn Gulas notifications@github.com wrote:

I think it would be helpful to show the different options for Smear results in the configurable column, because there might be a spacing issue, so hopefully you can tell us.

I'm referring to comments from Wasim in #34 (comment) https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569 .

  • In the Smear result form, the smear result answer choices (and the suggested label for the configurable column in parentheses) are:
  • 3+ (3+)
  • 2+ (2+)
  • 1+ (1+)
  • scanty (Scanty)
  • negative (Negative)

Note 1: Wasim suggested in #34 (comment) https://github.com/OpenSRP/opensrp-client-tbr/issues/34#issuecomment-346312569 to use "Sty" for scanty and "Neg" for negative, but since this is the only result shown, I think we can show the full word.

Note 2: I think all but negative would be red font, while negative would be black. But not so sure about scanty. @alihabib https://github.com/alihabib @kwasim https://github.com/kwasim thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/53, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKlUEgR060AyRA-M-b7OV7wSjGBJsks5tAi4agaJpZM4RDKPr .

rowo commented 6 years ago

smrresults

Here's a look at smear results in the SMR-only and results columns. So, to add or finalize what's above — we'll show any positive or scanty result in #c30000 whereas Negative shows up in #191919. When the column is smear result only, the full text can be shown for Scanty and Negative. When it's the smear result in an all results column, the text is shortened to Sty and Neg so that a culture result can fit.

cafootitt commented 6 years ago

Great, thanks @rowo. Think this looks great.

cafootitt commented 6 years ago

@githengi @ndegwamartin Ok, this one is ready to go. Please note how the smear results have to be abbreviated in the more general results column.

cafootitt commented 6 years ago

Lgtm