opensrp / opensrp-client-tbr

Other
2 stars 4 forks source link

Add advanced search screen #67

Open rowo opened 6 years ago

rowo commented 6 years ago

Separated from https://github.com/OpenSRP/opensrp-client-tbr/issues/45.

From Ali: "This would be a project-wide search (as opposed to a location specific search)."

From Wasim https://github.com/OpenSRP/opensrp-client-tbr/issues/45#issuecomment-358620275:

Possible advanced search parameters:

cafootitt commented 6 years ago

I would recommend changing 76-119 category to 76+

cafootitt commented 6 years ago

@kwasim There is no national ID in any of these forms, so we are removing this from advanced search mockup.

rowo commented 6 years ago

@cagulas @kwasim Basic form for advanced search. There would be a fixed "search" at the bottom. I kept the "status" idea from ZEIR, but can remove it.

advancedsearch-tbreach

cafootitt commented 6 years ago

Lgtm. @kwasim @alihabib Can we get a quick look and feedback by tomorrow? We are on an extremely tight timeline to get this wrapped up.

alihabib commented 6 years ago

Looks good to me too. I would say leave the status in

-- Sent from my mobile. Please excuse typos and brevity

On 22-Jan-2018 16:50, "Carolyn Gulas" notifications@github.com wrote:

Lgtm. @kwasim https://github.com/kwasim @alihabib https://github.com/alihabib Can we get a quick look and feedback by tomorrow? We are on an extremely tight timeline to get this wrapped up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/67#issuecomment-359401455, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKgF-_EY2_Ov_RjDmC72ITsXMol9gks5tNHX-gaJpZM4Riym- .

cafootitt commented 6 years ago

@alihabib Great, thanks for the quick look.

@githengi @ndegwamartin Changing this to an implementation issue now and assigning you both.

rowo commented 6 years ago

@githengi @ndegwamartin I'll be adding the "results" screen (both results found and empty states). It should be similar to ZEIR except smartphone (rather than tablet) focused. I will make a screen with the search button too. I was thinking it would be fixed (hovering over the form, at the bottom) rather than at the bottom of the list.

cafootitt commented 6 years ago

From @rowo - this would be the results after the search above:

advancedsearch-results

Error snackbar messages: 1) If you try to un-check all three status checkboxes: "Check at least one status to search." 2) If you hit the search button without having at least one search parameter field filled in: "Enter at least one search field."

alihabib commented 6 years ago

Looks good to me

Ali

Ali Habib Chief Executive Officer Interactive Health Solutions http://www.ihsinformatics.com

ali.habib@ihsinformatics.com

On Fri, Jan 26, 2018 at 11:42 AM, Carolyn Gulas notifications@github.com wrote:

From @rowo https://github.com/rowo - this would be the results after the search above:

[image: advancedsearch-results] https://user-images.githubusercontent.com/3488986/35427368-014cdba2-027a-11e8-885b-8fcb57d3cca2.png

  • The back arrow returns you to the first advanced search screen; the fields would still be filled in (only if you exit the advanced search would the fields be wiped)
  • Since by definition, all patients would have to be either presumptive, positive, or in-treatment, we should make sure that at least one checkbox is ticked for each search. By default, I think it makes sense for all 3 checkboxes to be checked.
  • In addition to the status, at least one search parameter field should be not empty when the user does the search.
  • The results screen would split the patients by status. The results screen shows at the top what you searched for.

Error snackbar messages:

  1. If you try to un-check all three status checkboxes: "Check at least one status to search."
  2. If you hit the search button without having at least one search parameter field filled in: "Enter at least one search field."

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSRP/opensrp-client-tbr/issues/67#issuecomment-360697456, or mute the thread https://github.com/notifications/unsubscribe-auth/ACytKj34QRyYKfX-F8A2S5mNzbHVzIsUks5tOXPpgaJpZM4Riym- .