Create lib jar file - Githubissues

opensrp / opensrp-server-openlmis

Other

1 stars 0 forks source link

Create lib jar file #11

Closed vincent-karuri closed 6 years ago

vincent-karuri commented 6 years ago

Configure opensrp-server-openlmis to build a jar file that can be imported into, among others, the OpenSRP server.

See issue #8

githengi commented 6 years ago

Some endpoints e.g dispensable, trade items, commodity types are not returning server versions on the get or sync endpoints

vincent-karuri commented 6 years ago

Having update and add on the same endpoint is not a good api design practice. POST should not be used to update as a convention. SG: Its a convention on OpenSRP batch endpoints ... incase OpenLMIS is not being used

Could you explain what this means? SG: Trade items, Commodity types, Orderables, etc will be maintained by an OpenSRP administrator . Having two endpoints and deciding whether its an update or new is a bit cumbersome

vincent-karuri commented 6 years ago

I have updated the json data and removed the server version when posting. Try using that data instead. Server versions show for me.

githengi commented 6 years ago

Batch POST endpoints do not update data.