search

openssh-rust / openssh

Scriptable SSH through OpenSSH in Rust
Apache License 2.0
232 stars 37 forks source link

Rm `From<OwnedFd> for Stdio` impl #82

Closed NobodyXu closed 2 years ago

NobodyXu commented 2 years ago

to avoid using io_lifetimes in public API.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

jonhoo commented 2 years ago

This change is Reviewable

NobodyXu commented 2 years ago

Looks like io-safety is finally going to be stablised in 1.63 https://github.com/rust-lang/rust/pull/95118

@jonhoo Should we wait for it instead and replace the crate io-lifetimes with the std counterparts?

NobodyXu commented 2 years ago

I'd like to remove it anyway in the interrim since as it stands it's a breaking change problem waiting to happen. Happy to add it back after 1.63 without the dependency.

@jonhoo Shall we create a new release and yield all the other 0.9.* release to ensure that no one depends on it?

jonhoo commented 2 years ago

I don't think this is quite worth the (user) friction of a yank given that there isn't actually a security risk to this. The fact that there is a breaking change is going to be mostly irrelevant to users.

jonhoo commented 2 years ago

Released as 0.9.2 :tada: