openssi / peer-did-method-spec

A spec for the did:peer DID method.
https://dhh1128.github.io/peer-did-method-spec/index.html
Apache License 2.0
30 stars 17 forks source link

turn on DCO #82

Closed dhh1128 closed 4 years ago

dhh1128 commented 5 years ago

I would like to turn on the DCO bot, and to go back through history and add a Signed-off-by note to any commits that lack it. Do any of our contributors object? @kdenhartog @TelegramSam @csmarc @Oskar-van-Deventer @SvenHammann90 @devin-fisher @brentzundel @mavarley

Background:

It's not clear whether this spec will end up being sponsored in a formal way by any standards body or open source umbrella project--but it seems moderately likely that one or more of the W3C, DIF, and/or Hyperledger might endorse it officially.

If that happens, one of the issues that will arise is whether all contributors to a spec are officially aligned with this repo's Apache 2 license (which has always been here). Specifically, they will want to be sure that nothing in the spec is encumbered by copyright or patents in any way.

Github has a way to officially prove that, which is through the DCO bot. I can turn that on now, which will begin enforcement from this point forward. I can also modify the log message from any old commits to clarify that this was the case for them, too. But I don't want to modify old commit messages from any of you unless you are comfortable with me doing so.

For reference, this is common practice in Hyperledger, where I have done a lot of work, because it makes all the lawyers happy and it forces collaborating developers to be crisp about IP.

SvenHammann90 commented 5 years ago

I agree to this, including modification of my old commit messages.

Kind Regards, Sven

kdenhartog commented 5 years ago

I believe I've been using DCO commit methods anyways. I'll double check my commits and amend them if they have problems.

brentzundel commented 5 years ago

I believe my commits are all signed as well, but will amend them if needed.

On Fri, Jul 12, 2019 at 1:04 PM Kyle Den Hartog notifications@github.com wrote:

I believe I've been using DCO commit methods anyways. I'll double check my commits and amend them if they have problems.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openssi/peer-did-method-spec/issues/82?email_source=notifications&email_token=ACPFKP63HDKU34YFETR5WHTP7DIUXA5CNFSM4ICKCEH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2TTNA#issuecomment-510998964, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPFKP4PRQ5IU5FOQDHXDJLP7DIUXANCNFSM4ICKCEHQ .

csmarc commented 5 years ago

I agree to this as well, and I turned on DCO.

Oskar-van-Deventer commented 5 years ago

I have no objection at turning on DCO, though I may need some help to get my PR's properly DCO-ed ...

By the way, what refrains us from moving the whole Peer DID spec to Hyperledger Aries? (I don't know the history of openssi, so please pardon my ignorance)

Oskar

dhh1128 commented 5 years ago

Moving this spec to a more permanent home is probably a good idea. However, all the candidates for a permanent homes had political problems when I began the work. Therefore, I deliberately placed this spec in the most generic, most unaffiliated place I could think of, for the time being, because I wanted it not to be strongly associated with any particular sponsor. I wanted people who encountered it to just evaluate it on the basis of its ideas, and to defer the question of its home (which is secondary) until later. Now that we have a significant collection of authors, I think we can ask them where they want to move it, and start developing a consensus about that question. I'll open a separate ticket about that.

dhh1128 commented 4 years ago

@peacekeeper , I can't see the settings on our new repo at DIF. Can you confirm that DCO check is enabled there?

dhh1128 commented 4 years ago

Opened a related issue in the new repo home: https://github.com/decentralized-identity/peer-did-method-spec/issues/18.